Sending Multi<Byte> as files in multipart in REST Client Reactive #21569

michalszynkiewicz · 2021-11-19T13:17:03Z

No description provided.

michalszynkiewicz · 2021-11-29T08:59:46Z

...e/src/main/java/io/quarkus/rest/client/reactive/runtime/devconsole/RestClientsContainer.java

@@ -68,7 +68,7 @@ public RestClientData getClientData() {

        public RestClientData(List<RestClientInfo> clients, List<PossibleRestClientInfo> possibleClients) {
            this.clients = clients;
-            this.possibleClients = possibleClients;
+            this.possibleClients = possibleClients; // TODO: present this info


this is not related to this PR, I just didn't want to lose this TODO

quarkus-bot · 2021-11-29T09:04:17Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `44c8956`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Failures	Logs	Raw logs
⌛	Attach pull request number		⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check		⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-11-29T11:24:12Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ffa1704`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc-code-flow

📦 integration-tests/oidc-code-flow

✖ io.quarkus.it.keycloak.CodeFlowTest.testIdTokenInjectionWithoutRestoredPath line 403 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/web-app/callback-after-redirect?state=50f9130f-f4c5-4e76-a835-d170f370036f&session_state=0fb6c27d-df72-4126-9544-d715e9d60cbf&code=81cf4a10-03ea-4077-bcdc-e0929fa8b43e.0fb6c27d-df72-4126-9544-d715e9d60cbf.169db77f-b8cf-4852-bc71-aef7c7a57017
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)

quarkus-bot · 2021-11-29T15:03:55Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `d567ab0`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 2 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

cescoffier

Looks very good. I would need to test it more.

There are some complicated classes that would deserve a bit of doc.

cescoffier · 2021-11-30T15:18:33Z

...ntime/src/main/java/org/jboss/resteasy/reactive/client/impl/multipart/MultiByteHttpData.java

+import org.jboss.logging.Logger;
+import org.reactivestreams.Subscription;
+
+public class MultiByteHttpData extends AbstractHttpData implements FileUpload {


You should explain how this class is intended to work.

I added some javadoc.

cescoffier · 2021-12-01T06:44:56Z

...ain/java/org/jboss/resteasy/reactive/client/impl/multipart/QuarkusMultipartFormDataPart.java

@@ -133,6 +160,10 @@ public Buffer content() {
        return content;
    }

+    public Multi<Byte> multiByteContent() {


Something we could improve (later) is to also support Multi<byte[]>, because it's what you receive most of the time (chunks, not bytes one by one).

quarkus-bot · 2021-12-02T08:24:24Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b224f95`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/resteasy-reactive/client/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 214 more

📦 independent-projects/resteasy-reactive/client/runtime

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project resteasy-reactive-client: File '/home/runner/work/quarkus/quarkus/independent-projects/resteasy-reactive/client/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/multipart/MultiByteHttpData.java' has not been previously formatted. Please format file and commit before running validation!

quarkus-bot bot added the area/rest label Nov 19, 2021

michalszynkiewicz force-pushed the rest-client-reactive-multi-as-file-multipart branch from 30a4eb1 to 44c8956 Compare November 29, 2021 08:58

michalszynkiewicz marked this pull request as ready for review November 29, 2021 08:59

michalszynkiewicz requested a review from cescoffier November 29, 2021 08:59

michalszynkiewicz commented Nov 29, 2021

View reviewed changes

michalszynkiewicz force-pushed the rest-client-reactive-multi-as-file-multipart branch 2 times, most recently from e3d9f4d to ffa1704 Compare November 29, 2021 09:00

michalszynkiewicz force-pushed the rest-client-reactive-multi-as-file-multipart branch from ffa1704 to d567ab0 Compare November 29, 2021 12:35

cescoffier requested changes Dec 1, 2021

View reviewed changes

michalszynkiewicz force-pushed the rest-client-reactive-multi-as-file-multipart branch from d567ab0 to b224f95 Compare December 2, 2021 08:13

Sending Multi<Byte> as files in multipart in REST Client Reactive

395c5f0

michalszynkiewicz force-pushed the rest-client-reactive-multi-as-file-multipart branch from b224f95 to 395c5f0 Compare December 2, 2021 09:41

michalszynkiewicz requested a review from cescoffier December 2, 2021 21:40

cescoffier approved these changes Dec 3, 2021

View reviewed changes

michalszynkiewicz merged commit 4757a61 into quarkusio:main Dec 6, 2021

quarkus-bot bot added this to the 2.6 - main milestone Dec 6, 2021

michalszynkiewicz mentioned this pull request Dec 6, 2021

Allow large file download and upload using the Reactive REST Client. #21440

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sending Multi<Byte> as files in multipart in REST Client Reactive #21569

Sending Multi<Byte> as files in multipart in REST Client Reactive #21569

michalszynkiewicz commented Nov 19, 2021

michalszynkiewicz Nov 29, 2021

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `44c8956`

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `ffa1704`

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/oidc-code-flow

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `d567ab0`

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

cescoffier left a comment

cescoffier Nov 30, 2021

michalszynkiewicz Dec 2, 2021

cescoffier Dec 1, 2021

quarkus-bot bot commented Dec 2, 2021 •

edited

Loading

Failing Jobs - Building `b224f95`

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/resteasy-reactive/client/runtime

Sending Multi<Byte> as files in multipart in REST Client Reactive #21569

Sending Multi<Byte> as files in multipart in REST Client Reactive #21569

Conversation

michalszynkiewicz commented Nov 19, 2021

michalszynkiewicz Nov 29, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Nov 29, 2021 • edited Loading

Failing Jobs - Building 44c8956

quarkus-bot bot commented Nov 29, 2021 • edited Loading

Failing Jobs - Building ffa1704

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/oidc-code-flow

quarkus-bot bot commented Nov 29, 2021 • edited Loading

Failing Jobs - Building d567ab0

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

cescoffier left a comment

Choose a reason for hiding this comment

cescoffier Nov 30, 2021

Choose a reason for hiding this comment

michalszynkiewicz Dec 2, 2021

Choose a reason for hiding this comment

cescoffier Dec 1, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Dec 2, 2021 • edited Loading

Failing Jobs - Building b224f95

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/resteasy-reactive/client/runtime

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `44c8956`

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `ffa1704`

quarkus-bot bot commented Nov 29, 2021 •

edited

Loading

Failing Jobs - Building `d567ab0`

quarkus-bot bot commented Dec 2, 2021 •

edited

Loading

Failing Jobs - Building `b224f95`