When launching a container via @QuarkusIntegrationTest make network available #21316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable This is pretty much the same as we did in 21287, but it now works regardless of the presence of DevServices. The difference with containers launched by DevServices, is that in this case we now need to manage the creation and deletion of the network, whereas in the case of DevServices we got that for free by utilizing testcontainers Resolves: quarkusio#19080
stuartwdouglas
approved these changes
Nov 9, 2021
gastaldi
reviewed
Nov 10, 2021
| @@ -330,6 +335,11 @@ public String networkId() { | |||
| return networkId; | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean manageNetwork() { | |||
There was a problem hiding this comment.
Isn't this the same as checking if networkId == null?
There was a problem hiding this comment.
No, actually it isn't - we only want to manage the network when it's not already done by test containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much the same as we did in 21287, but it now works
regardless of the presence of DevServices.
The difference with containers launched by DevServices, is that in this
case we now need to manage the creation and deletion of the network,
whereas in the case of DevServices we got that for free
by utilizing testcontainers
Resolves: #19080