Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure maven-settings.xml is generated outside the working dir #21268

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Nov 8, 2021

This prevents the file from being accidentally committed in the repository if the release script changes for some reason

This prevents the file from being accidentally committed in the repository
@gastaldi gastaldi requested a review from aloubyansky November 8, 2021 11:47
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 8, 2021
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet wdyt?

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 8, 2021
@gastaldi gastaldi merged commit fea358f into quarkusio:main Nov 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 8, 2021
@gastaldi gastaldi deleted the tmp branch November 8, 2021 16:28
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 8, 2021
@gsmet gsmet modified the milestones: 2.5.0.CR1, 2.4.2.Final Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants