Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initCommands to Vault Dev Services configuration #21259

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Nov 8, 2021

Allows custom vault commands to be run on dev services container startup.

Allows custom vault commands to be run on dev services container startup.
@kdubb kdubb force-pushed the feature/vault_ds_config branch from 2858c48 to 7d769fb Compare November 8, 2021 06:40
@geoand geoand requested a review from vsevel November 8, 2021 10:12
@vsevel
Copy link
Contributor

vsevel commented Nov 8, 2021

LGTM.
I do not see any test.
@geoand that is not possible to have integration testing on dev services?
I searched through the codebase, and found only one occurence of quarkus.XX.devservices.enabled=true in all the integration tests (it is in quarkus-integration-test-micrometer-prometheus).
in this particular case, I see the withInitCommand has already been used for the transit and pki engines init. so we will be fine. but just wondering. what is the expected level of testing for devservices?

@geoand
Copy link
Contributor

geoand commented Nov 8, 2021

Dev Services are enabled by default, so plenty of integration tests use them, for example https://github.com/quarkusio/quarkus/blob/2.4.1.Final/integration-tests/mongodb-rest-data-panache/pom.xml

@kdubb
Copy link
Contributor Author

kdubb commented Nov 8, 2021

As far as I remember (I could be wrong) Vault ITs don't use dev services currently. So, I was being a bit lazy and didn't want to devise a whole new test scheme for this two line addition 😏

@geoand geoand merged commit 5985342 into quarkusio:main Nov 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 8, 2021
@kdubb kdubb deleted the feature/vault_ds_config branch November 8, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants