Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST Client codestart #21229

Merged
merged 1 commit into from
Nov 8, 2021
Merged

REST Client codestart #21229

merged 1 commit into from
Nov 8, 2021

Conversation

xstefank
Copy link
Member

@xstefank xstefank commented Nov 5, 2021

Resolves #20555

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Nov 5, 2021
@xstefank
Copy link
Member Author

xstefank commented Nov 5, 2021

@ia3andy can you review please?

@ia3andy
Copy link
Contributor

ia3andy commented Nov 5, 2021

Hey @xstefank, it looks nice!

Could you put the Extension as an inner class (we try to have only one file/codestart when possible)?

@xstefank
Copy link
Member Author

xstefank commented Nov 5, 2021

@ia3andy updated.

@ia3andy
Copy link
Contributor

ia3andy commented Nov 5, 2021 •
edited
Loading

What do you think of naming the class MyRemoteService and the method getExtensionsById(...) (and add the @path on the method)?

This is meant to make it easier to find (locate and identify) this across different extensions codestarts in the same project..

@xstefank
Copy link
Member Author

xstefank commented Nov 5, 2021

@ia3andy ok, applied your suggestions.

ia3andy
ia3andy approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for CI :)

@ia3andy ia3andy merged commit 88f2e6c into quarkusio:main Nov 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 8, 2021
@rsvoboda rsvoboda mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging this pull request may close these issues.

Rest Client codestart (in java and kotlin)
3 participants
@xstefank @ia3andy @gsmet