Mmaler reviewing samllrye metrics #21197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
requested changes
Nov 9, 2021
|
@jmartisk Hello Jan! I updated what I have could with respect to let this be written in the upstream way, which as you said is good for consistency. |
|
@MichalMaler LGTM, just please squash it into one commit before we merge |
MichalMaler
force-pushed
the
mmaler-reviewing-samllrye-metrics
branch
from
6dbcbcc to
4df39b8
Compare
Signed-off-by: Michal Maléř <[email protected]> Language and style Signed-off-by: Michal Maléř <[email protected]> Prereq-update Signed-off-by: Michal Maléř <[email protected]> Review-JMartisk's Suggestions Signed-off-by: Michal Maléř <[email protected]>
MichalMaler
force-pushed
the
mmaler-reviewing-samllrye-metrics
branch
from
4df39b8 to
720be46
Compare
jmartisk
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a review for a procedure written by Jan Martiška and other Quarkus contributors :)