Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling Hibernate Search through configuration properties #21161

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Allow disabling Hibernate Search through configuration properties #21161

merged 3 commits into from
Nov 3, 2021

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Nov 3, 2021

No description provided.

@yrodiere yrodiere requested a review from gsmet November 3, 2021 08:29
@quarkus-bot quarkus-bot bot added the area/hibernate-search Hibernate Search label Nov 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 3, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 47731e8

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/hibernate-search-orm-elasticsearch-aws/deployment 
! Skipped: docs integration-tests/hibernate-search-orm-elasticsearch-aws

📦 extensions/hibernate-search-orm-elasticsearch-aws/deployment

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-hibernate-search-orm-elasticsearch-aws-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/hibernate-search-orm-elasticsearch-aws/deployment/src/main/java/io/quarkus/hibernate/search/orm/elasticsearch/aws/HibernateSearchOrmElasticsearchAwsProcessor.java

@yrodiere yrodiere force-pushed the hsearch-no-failure-when-disabled branch from 47731e8 to d23ef9f Compare November 3, 2021 08:47
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 3, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d23ef9f

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/hibernate-search-orm-elasticsearch-aws/deployment 
! Skipped: docs integration-tests/hibernate-search-orm-elasticsearch-aws

📦 extensions/hibernate-search-orm-elasticsearch-aws/deployment

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-hibernate-search-orm-elasticsearch-aws-deployment: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/hibernate-search-orm-elasticsearch-aws/deployment/src/test/java/io/quarkus/hibernate/search/elasticsearch/aws/test/configuration/NonIndexedEntity.java

@yrodiere
Avoid failures caused by invalid configuration when Hibernate Search …
d725bc8 
…is disabled because there are no indexed entities
@yrodiere
Avoid failures caused by invalid configuration when Hibernate Search …
f146e82 
…is disabled explicitly

It was already almost implemented, but the implementation code was not
being used. This commit fixes that.
@yrodiere yrodiere force-pushed the hsearch-no-failure-when-disabled branch from d23ef9f to f146e82 Compare November 3, 2021 09:32
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 3, 2021
@yrodiere yrodiere merged commit 879c4fb into quarkusio:main Nov 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 3, 2021
@yrodiere yrodiere added the kind/enhancement New feature or request label Nov 3, 2021
@yrodiere yrodiere deleted the hsearch-no-failure-when-disabled branch May 31, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/hibernate-search Hibernate Search kind/enhancement New feature or request
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@yrodiere @gsmet