Don't rely on the '--rm' flag for stopping containers in integration tests #21119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-framework/common/src/main/java/io/quarkus/test/common/DefaultDockerContainerLauncher.java
Show resolved
Hide resolved
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 09efd94
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/vault-agroal
📦 integration-tests/vault-agroal✖ ✖ ✖ ⚙️ Native Tests - Windows - hibernate-validator #- Failing: integration-tests/hibernate-validator
📦 integration-tests/hibernate-validator✖ |
gastaldi
reviewed
Nov 1, 2021
test-framework/common/src/main/java/io/quarkus/test/common/DefaultDockerContainerLauncher.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Nov 1, 2021
test-framework/common/src/main/java/io/quarkus/test/common/DefaultDockerContainerLauncher.java
Outdated
Show resolved
Hide resolved
…tests It seems that this flag is not very reliable on some cases in Windows, so we just give the container a name and use that name to manually stop the container. Fixes: quarkusio#21101
gastaldi
approved these changes
Nov 1, 2021
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this flag is not very reliable on some cases in Windows,
so we just give the container a name and use that name to manually
stop the container.
Fixes: #21101