Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply polish to StaticResourcesRecorder #21057

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 28, 2021

  • Remove knownPaths field
  • Remove lambdas

@stuartwdouglas
Copy link
Member

Can't you just remove the static and pass the set straight to the start method? This may have made sense when it was part of Servlet bootstrap, but I don't think it is needed now.

@geoand geoand force-pushed the vertx-http-polish branch from d610981 to 24702dd Compare October 28, 2021 05:39
@geoand
Copy link
Contributor Author

geoand commented Oct 28, 2021

Let's see what CI says

* Remove knownPaths field
* Remove lambdas
@geoand geoand force-pushed the vertx-http-polish branch from 24702dd to c13728c Compare October 28, 2021 05:40
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 28, 2021

Failing Jobs - Building c13728c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Security3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/reactive-messaging-rabbitmq 

📦 integration-tests/reactive-messaging-rabbitmq

io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <2> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ Native Tests - Security3 #

- Failing: integration-tests/vault-agroal 

📦 integration-tests/vault-agroal

io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

@geoand
Copy link
Contributor Author

geoand commented Oct 28, 2021

CI passed

@geoand
Copy link
Contributor Author

geoand commented Oct 29, 2021

Is this OK with you @stuartwdouglas ?

@geoand geoand merged commit 07da260 into quarkusio:main Oct 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 29, 2021
@geoand geoand deleted the vertx-http-polish branch October 29, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants