-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply polish to StaticResourcesRecorder #21057
Conversation
geoand
commented
Oct 28, 2021
•
edited
Loading
edited
- Remove knownPaths field
- Remove lambdas
aee16e9
to
d610981
Compare
Can't you just remove the static and pass the set straight to the start method? This may have made sense when it was part of Servlet bootstrap, but I don't think it is needed now. |
d610981
to
24702dd
Compare
Let's see what CI says |
* Remove knownPaths field * Remove lambdas
24702dd
to
c13728c
Compare
Failing Jobs - Building c13728c
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/reactive-messaging-rabbitmq
📦 integration-tests/reactive-messaging-rabbitmq✖
⚙️ Native Tests - Security3 #- Failing: integration-tests/vault-agroal
📦 integration-tests/vault-agroal✖
✖
✖
|
CI passed |
Is this OK with you @stuartwdouglas ? |