Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all plugins are versioned #21022

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

stuartwdouglas
Copy link
Member

This adds an enforcer rule to make sure every plugin has a specified
version.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Oct 26, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e2c0938

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

@geoand geoand requested a review from famod October 27, 2021 05:48
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used that rule and I'm wondering what's the "proper" phase (default is clean,deploy,site), but as long as it works as expected... 🤷‍♂️

PS: Wondering whether we should add properties for the rest of the plugins as well (e.g. impsort-maven-plugin).

@stuartwdouglas
Copy link
Member Author

I will update this to add properties for all of them.

@stuartwdouglas
Copy link
Member Author

With regards to the phase 'clean, deploy, site' did not make much sense to me as these are not run as part of a normal build.

@famod
Copy link
Member

famod commented Oct 27, 2021

With regards to the phase 'clean, deploy, site' did not make much sense to me as these are not run as part of a normal build.

Yeah, that's why I'm confused a bit about that default.

@famod
Copy link
Member

famod commented Oct 27, 2021

Btw, that com.google.code.maven-replacer-plugin entry seems to be obsolete.
In fact, its artifactId looks off; should be replacer, not maven-resources-plugin (which underlines that it should go).

This adds an enforcer rule to make sure every plugin has a specified
version.
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 28, 2021

Failing Jobs - Building 98366fc

Status Name Step Failures Logs Raw logs
Native Tests - Messaging2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq 

📦 integration-tests/reactive-messaging-rabbitmq

io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants