-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure all plugins are versioned #21022
Conversation
This workflow status is outdated as a new workflow run has been triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used that rule and I'm wondering what's the "proper" phase
(default is clean,deploy,site
), but as long as it works as expected... 🤷♂️
PS: Wondering whether we should add properties for the rest of the plugins as well (e.g. impsort-maven-plugin).
I will update this to add properties for all of them. |
With regards to the phase 'clean, deploy, site' did not make much sense to me as these are not run as part of a normal build. |
Yeah, that's why I'm confused a bit about that default. |
e2c0938
to
0d19ab9
Compare
Btw, that |
This adds an enforcer rule to make sure every plugin has a specified version.
0d19ab9
to
98366fc
Compare
Failing Jobs - Building 98366fc
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Messaging2 #- Failing: integration-tests/reactive-messaging-rabbitmq
📦 integration-tests/reactive-messaging-rabbitmq✖
|
This adds an enforcer rule to make sure every plugin has a specified
version.