Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon Secrets Manager extension based on pattern of SSM extension #21014

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

corentinarnaud
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Oct 26, 2021
@sberyozkin
Copy link
Member

@corentinarnaud Hi, can you also look at providing a CredentialsProvider support please ? See https://quarkus.io/guides/credentials-provider ?

@corentinarnaud
Copy link
Contributor Author

@corentinarnaud Hi, can you also look at providing a CredentialsProvider support please ? See https://quarkus.io/guides/credentials-provider ?

@sberyozkin Hi, I am trying to add support to CredentialsProvider (I have made a branch on my github https://github.com/corentinarnaud/quarkus/tree/secrets-manager-credential-provider)
but It doesn't work, and I do not know why. I don't really understand how deployment module work.

@gsmet
Copy link
Member

gsmet commented Nov 2, 2021

Interesting, I'll have a closer look this week. Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 2, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0709b7a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Messaging2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-rabbitmq 

📦 integration-tests/reactive-messaging-rabbitmq

io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/vault-agroal 

📦 integration-tests/vault-agroal

io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq 

📦 integration-tests/reactive-messaging-rabbitmq

io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@corentinarnaud corentinarnaud force-pushed the secrets-manager-extentions branch from 0709b7a to c707cf3 Compare November 29, 2021 12:39
@gsmet gsmet force-pushed the secrets-manager-extentions branch from c707cf3 to b11052b Compare December 2, 2021 19:05
@gsmet
Copy link
Member

gsmet commented Dec 2, 2021

Sorry it took me so long. Overall, it looks good, let's see what CI has to say. I plan to move the Amazon Services to the Quarkiverse very soon so I would like to get this in before the move.

@gsmet
Copy link
Member

gsmet commented Dec 2, 2021

I force pushed a rebase to make sure we test the current state of things.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed! Let's get this in and I'll start with the move to Quarkiverse today.

@gsmet gsmet merged commit cd8fde5 into quarkusio:main Dec 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 3, 2021
@gsmet
Copy link
Member

gsmet commented Dec 3, 2021

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants