Qute parameter declarations - autoimport java.lang if needed #21007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Oct 26, 2021
mkouba
commented
- resolves Qute parameter declarations - allow referring to java.lang.String as just String #20975
gastaldi
reviewed
Oct 27, 2021
| if (!rawClassName.toString().contains(".")) { | ||
| // Try the java.lang prefix for a name without package | ||
| rawClassName = DotName.createSimple(Types.JAVA_LANG_PREFIX + rawClassName.toString()); | ||
| clazz = index.getClassByName(rawClassName); |
There was a problem hiding this comment.
Didn't know that java.lang classes were jandexed too
There was a problem hiding this comment.
They're not ;-). But we try to index unknown classes on demand. At least in the bean archive index. For the combined index you would need to use CombinedIndexBuildItem.getComputingIndex() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.