Don't include non-configured data sources in health checks #21003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/agroal
area/persistence
gsmet
requested changes
Oct 26, 2021
| Set<String> names = support.getConfiguredNames(); | ||
| Set<String> excludedNames = support.getExcludedNames(); | ||
| for (String name : names) { | ||
| DataSource ds = name.equals(DataSourceUtil.DEFAULT_DATASOURCE_NAME) |
There was a problem hiding this comment.
Please use DataSourceUtil.isDefault().
| boolean isDefault = DEFAULT_DS.equals(dataSource.getKey()); | ||
| try (Connection con = dataSource.getValue().getConnection()) { | ||
| boolean valid = con.isValid(0); | ||
| boolean isDefault = DataSourceUtil.DEFAULT_DATASOURCE_NAME.equals(dataSource.getKey()); |
There was a problem hiding this comment.
Please use DataSourceUtil.isDefault().
| for (String name : names) { | ||
| DataSource ds = name.equals(DataSourceUtil.DEFAULT_DATASOURCE_NAME) | ||
| ? (DataSource) Arc.container().instance(DataSource.class).get() | ||
| : (DataSource) Arc.container().instance(name).get(); |
There was a problem hiding this comment.
Could you use instance(Class<T> type, Annotation... qualifiers) instead? You have DataSourceLiteral for this purpose.
jmartisk
force-pushed
the
main-issue-20950
branch
from
a69e05e to
b836d84
Compare
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building b836d84
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/agroal/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 137 more📦 extensions/agroal/runtime✖ |
jmartisk
force-pushed
the
main-issue-20950
branch
from
b836d84 to
e585673
Compare
gsmet
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20950