Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override BUILD_AND_RUN_TIME_FIXED properties #20932

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Do not override BUILD_AND_RUN_TIME_FIXED properties #20932

merged 1 commit into from
Oct 22, 2021

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Oct 21, 2021 •
edited
Loading

geoand
geoand reviewed Oct 21, 2021
View reviewed changes
core/test-extension/deployment/src/test/java/io/quarkus/extest/ConfiguredBeanTest.java Outdated
@@ -339,7 +343,13 @@ public void testConfigDefaultValuesSourceOrdinal() {
assertEquals(Integer.MIN_VALUE + 100, defaultValues.getOrdinal());

// Should be the first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is no longer valid, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Let me remove it.

geoand
geoand approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 21, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1e58855

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/vault-agroal

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

@geoand geoand merged commit 8e5722d into quarkusio:main Oct 22, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 22, 2021
@radcortez radcortez deleted the fix-17614 branch November 22, 2021 21:56
@radcortez radcortez linked an issue Nov 25, 2021 that may be closed by this pull request
BUILD_AND_RUN_TIME_FIXED configuration is not actually fixed #19438
Closed
@radcortez radcortez mentioned this pull request Nov 25, 2021
Closed
@radcortez radcortez mentioned this pull request Jun 22, 2022
Closed
@radcortez radcortez mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/config area/core
Projects
None yet
Milestone
2.5.0.CR1
2 participants
@radcortez @geoand