Make use of conditional dependencies in rest data panache #20893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
geoand
commented
Oct 20, 2021
Comment on lines
+70
to
+75
| resteasyJaxrsProviderBuildItemBuildProducer | ||
| .produce(new ResteasyJaxrsProviderBuildItem(SortQueryParamFilter.class.getName())); | ||
| } else { | ||
| containerRequestFilterBuildItemBuildProducer | ||
| .produce(new ContainerRequestFilterBuildItem.Builder(SortQueryParamFilter.class.getName()) | ||
| .setNameBindingNames(Collections.singleton(SortQueryParamValidator.class.getName())).build()); |
There was a problem hiding this comment.
This is now needed because the dependency is now properly treated as a Quarkus extension runtime part and therefore not indexed
geoand
force-pushed
the
rest-data-panache-conditional-deps
branch
from
5938fd2 to
b3056b4
Compare
quarkus-bot
bot
added
the
area/devtools
geoand
commented
Oct 20, 2021
Comment on lines
+1454
to
+1463
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy-links</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy-links-deployment</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
This new extension doesn't really do much, it's just needed in order to take advantage of the conditional dependencies feature
geoand
force-pushed
the
rest-data-panache-conditional-deps
branch
from
b3056b4 to
ba38cf3
Compare
geoand
commented
Oct 20, 2021
Comment on lines
+65
to
+84
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-bootstrap-maven-plugin</artifactId> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <annotationProcessorPaths> | ||
| <path> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-extension-processor</artifactId> | ||
| <version>${project.version}</version> | ||
| </path> | ||
| </annotationProcessorPaths> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
For some reason this was not present in the extension. Obviously it's needed in order to properly setup the metadata needed for the extension to work with conditional dependencies
aloubyansky
approved these changes
Oct 20, 2021
geoand
added
the
triage/waiting-for-ci
geoand
force-pushed
the
rest-data-panache-conditional-deps
branch
from
ba38cf3 to
e2dee5b
Compare
This way users don't have to manually add specify the links implementation for their flavor of RESTEasy
geoand
force-pushed
the
rest-data-panache-conditional-deps
branch
from
e2dee5b to
f12f18a
Compare
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users don't have to manually add specify the links
implementation for their flavor of RESTEasy
Follows up on #20874