Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Undertow to work with RESTEasy Reactive #20886

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

stuartwdouglas
Copy link
Member

Note that this integration is different to the integration provided by
resteasy-reactive-servlet or the RESTEasy classic integration. This
allows RESTEasy Reactive to run before Servlet, and delegate any
unmatched requests to the Servlet container. If RESTEasy reactive
matches then Servlet is not involved in the request handling.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c8188a4

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - HTTP Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/resteasy-reactive-kotlin/standard 

📦 integration-tests/resteasy-reactive-kotlin/standard

io.quarkus.it.resteasy.reactive.kotlin.ReactiveGreetingResourceTest.testResource line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/resteasy-reactive-kotlin/standard 

📦 integration-tests/resteasy-reactive-kotlin/standard

io.quarkus.it.resteasy.reactive.kotlin.ReactiveGreetingResourceTest.testResource line 16 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

⚙️ Native Tests - HTTP #

- Failing: integration-tests/resteasy-reactive-kotlin/standard 

📦 integration-tests/resteasy-reactive-kotlin/standard

io.quarkus.it.resteasy.reactive.kotlin.NativeReactiveGreetingResourceIT.testResource - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

@stuartwdouglas
Copy link
Member Author

Turns out I missed something fairly obvious, this needs a bit more work to allow it to work correctly.

@geoand
Copy link
Contributor

geoand commented Oct 20, 2021

👌

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 20, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ace9127

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment 
! Skipped: docs 

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment

io.quarkus.resteasy.reactive.server.servlet.test.ServletSimpleRestTestCase.simpleTest - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <404> but was <500>.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment 
! Skipped: docs 

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment

io.quarkus.resteasy.reactive.server.servlet.test.ServletSimpleRestTestCase.simpleTest - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <404> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: docs integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron and 3 more

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-servlet/deployment

io.quarkus.resteasy.reactive.server.servlet.test.ServletSimpleRestTestCase.simpleTest - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <404> but was <500>.

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

Note that this integration is different to the integration provided by
resteasy-reactive-servlet or the RESTEasy classic integration. This
allows RESTEasy Reactive to run before Servlet, and delegate any
unmatched requests to the Servlet container. If RESTEasy reactive
matches then Servlet is not involved in the request handling.
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 21, 2021

Failing Jobs - Building b9b6ab8

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: docs integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron and 3 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants