Add an Hibernate ORM codestart #20879

loicmathieu · 2021-10-19T15:57:41Z

No description provided.

...quarkus/extension-codestarts/hibernate-orm-codestart/base/src.main.resources/application.yml

loicmathieu · 2021-10-20T10:11:23Z

Hibernate ORM codestart.
It will create a simple JPA entity, and import.sql that creates 3 entities inside the DB and a unit test that inject an entity manager and list the existing entities.

@FroMage @Sanne is it OK so we can move on to the more complex and debatable 'with Panacge' one ?

ia3andy · 2021-10-20T10:13:22Z

@loicmathieu will the import.sql work with any type of db?

loicmathieu · 2021-10-20T12:00:37Z

@loicmathieu will the import.sql work with any type of db?

I think so as it's standard SQL with no reserved word in it, I think. But maybe @Sanne knows better.
I can remove it and insert items inside the unit tests.

quarkus-bot · 2021-10-20T12:32:13Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `d353d27`

Status	Name	Step	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 77 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 60 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 84 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 77 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 60 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 84 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-c104dc43-0be3-4b5c-981c-7b5ffaa9edde

✖ org.acme.HelloGrpcServiceTest.testHello - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.hibernate.orm.deployment.HibernateOrmProcessor#configurationDescriptorBuilding threw an exception: io.quarkus.runtime.configuration.ConfigurationException: Model classes are defined for the default persistence unit, but no default datasource was found. The default EntityManagerFactory will not be created. To solve this, configure the default datasource. Refer to https://quarkus.io/guides/datasource for guidance.

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 77 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 60 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 84 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradle(String)[1] line 77 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testRunTogetherCodestartsJava line 60 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartBuildIT.testGradleKotlinDSL(String)[1] line 84 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-78cb4975-169b-417a-abb5-b36c36e4d717

✖ org.acme.GreetingResourceTest.testHelloEndpoint - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.hibernate.orm.deployment.HibernateOrmProcessor#configurationDescriptorBuilding threw an exception: io.quarkus.runtime.configuration.ConfigurationException: Model classes are defined for the default persistence unit, but no default datasource was found. The default EntityManagerFactory will not be created. To solve this, configure the default datasource. Refer to https://quarkus.io/guides/datasource for guidance.

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.GrpcMultiModuleQuarkusBuildTest.testProtocErrorOutput line 39 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)

loicmathieu · 2021-10-20T12:36:06Z

@ia3andy the build fails because I didn't add any datasource to the quickstart test. Should I disable the codestartTest.buildAllProjects(); or should I add an SQL extension (like H2) ?

ia3andy · 2021-10-20T14:44:30Z

@ia3andy the build fails because I didn't add any datasource to the quickstart test. Should I disable the codestartTest.buildAllProjects(); or should I add an SQL extension (like H2) ?

I am not sure :-/

Sanne · 2021-10-20T16:46:01Z

@loicmathieu will the import.sql work with any type of db?

I think so as it's standard SQL with no reserved word in it, I think. But maybe @Sanne knows better. I can remove it and insert items inside the unit tests.

Indeed it looks like standard SQL but it won't work on DBs which don't support sequences.

loicmathieu · 2021-10-20T17:35:00Z

Well I didn't think about databases that didn't support sequences.
Is it very common so we should remove the import.sql or is it rare so a comment on the file is enough?

loicmathieu · 2021-10-20T17:39:43Z

MySql didn't support sequences so I'll remove the import.sql file and I create the items manually.

ia3andy · 2021-10-20T17:58:14Z

@loicmathieu you don't have to delete it, just detect which db is selected using the list of extension, if you don't know, you keep it commented. wdyt?

loicmathieu · 2021-10-21T07:46:05Z

@ia3andy it may be difficult to list the db that support/didn't support sequences, and how would we treat 'other' ? And if we comment it the proposed unit test will not work.
I think it's best to remove it, or hardcode the id (but in this case you will not be able to create an entity as it will clash with the manually inserted lines).

ia3andy · 2021-10-21T09:15:34Z

@ia3andy it may be difficult to list the db that support/didn't support sequences, and how would we treat 'other' ? And if we comment it the proposed unit test will not work. I think it's best to remove it, or hardcode the id (but in this case you will not be able to create an entity as it will clash with the manually inserted lines).

So keep the import.sql file but comment the lines and remove the test I would suggest

loicmathieu · 2021-10-21T09:30:45Z

@ia3andy the test is the way to show how to use Hibernate ORM (inject and EM and work with it) so it should stay.
A commented file is not very usefull, I can keep it with all lignes commented but I really think we should keep the test.

ia3andy · 2021-10-21T14:38:40Z

@loicmathieu how will the test work without any data?

loicmathieu · 2021-10-21T15:21:43Z

@ia3andy the test is really to show how to use a JPA entity for someone how don't know, most of the time it will be deleted and replaced by a REST endpoint, a reactive messaging method or a main.

In the test I will create three entity, persist them and retrieve them. Not a good unit test but a way to show how to use Hibernate ORM.

ia3andy · 2021-10-21T15:39:08Z

TBH I would not keep the test if it's meant to be deleted.. the initial code is not here to teach or show anything (the guide and quickstart are here for this). It's meant for people who already know how to use it and like having a head start.

loicmathieu · 2021-10-21T16:15:23Z

So there is no point of having anything for Hibernate ORM as it will always be deleted.
Honestly, only creating a dump entity provides nothing for me.
If we didn't show that to use it we need to inject the EntityManager somewhere I don't see the point.

I updated my proposal with an import.sql with everything commented and a test that show the usage.

ia3andy · 2021-11-05T17:07:04Z

@loicmathieu failure seems unrelated..

ia3andy

Thanks @loicmathieu.. I am not sure if we should iterate on this PR with new commits for panache et reactive or create new PRs. I believe we should be fine with multiple PRs.

loicmathieu · 2021-11-08T09:12:30Z

I can provide a Kotlin version tomorrow so we can merge this one with it.
I'll provide separate PR for the other extension.

ia3andy · 2021-11-08T10:30:48Z

@loicmathieu maybe it would be easier to:

Make it "generic" and used by all the target extensions
Add Kotlin

WDYT?

loicmathieu · 2021-11-08T10:36:26Z

I don't think it's feasible to make it a generic one as the Panache version will be different, in fact all versions will be different as the javadoc contains the way to use it.

ia3andy · 2021-11-08T10:39:06Z

I don't think it's feasible to make it a generic one as the Panache version will be different, in fact all versions will be different as the javadoc contains the way to use it.

by generic I meant that it works with the different cases by altering the content depending on the selection. I didn't mean we we should have a "generic" content which fits all cases.

ia3andy · 2021-11-08T10:39:48Z

Like this: https://github.com/vgallet/quarkus/blob/issue20872/devtools/project-core-extension-codestarts/src/main/resources/codestarts/quarkus/extension-codestarts/reactive-messaging-codestart/base/src/main/resources/application.tpl.qute.yml

loicmathieu · 2021-11-09T08:33:39Z

@ia3andy I still thinks this will be too much work for almost no benefits, each extension will share very little code so almost all lines will be templated. This would just add complexity

ia3andy · 2021-11-09T08:37:33Z

@loicmathieu I think we can separate reactive from the others, but hibernate and hibernate with panache may be selected together in the list, right? The generic approach let us make sure we don't have both in the same project while in the end only panache is needed..

ia3andy · 2021-11-09T09:02:46Z

ex:
hibernate + panache = panache entity
hibernate = hibernate entity
panache = panache entity

loicmathieu · 2021-11-09T09:09:03Z

@ia3andy well, yes, this was my plan, conditionaly add different body to the MyEntity file when Panache is selected. I tought you mean having a base file that is modified via template.
When I'll implement the Panache codestart I'll modify this one to add the conditional stuff.

ia3andy · 2021-11-09T09:11:06Z

@ia3andy well, yes, this was my plan, conditionaly add different body to the MyEntity file when Panache is selected. I tought you mean having a base file that is modified via template. When I'll implement the Panache codestart I'll modify this one to add the conditional stuff.

ok cool :)

loicmathieu · 2021-11-09T16:16:21Z

@ia3andy I added the Kotlin version. Please make a final review before merging this one; I'll then create the others for Panache/reactive/mongo.

quarkus-bot · 2021-11-09T18:50:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `45ee91d`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Windows - hibernate-validator	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.InjectQuarkusAppPropertiesDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator

📦 integration-tests/hibernate-validator

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

ia3andy · 2021-11-09T19:49:31Z

...tension-codestarts/hibernate-orm-codestart/kotlin/src/main/kotlin/org/acme/MyKotlinEntity.kt

+ * }
+ */
+@Entity
+class MyKotlinEntity {


would it make sense to use a kotlin data object?

ia3andy · 2021-11-10T07:24:12Z

@loicmathieu could you investigate the gradle dev mode test to find out it it's related to the codestart?

Maybe you should rebase from main?

loicmathieu · 2021-11-10T09:35:12Z

@ia3andy as it's only on Windows, only on Gradle, not related to codestart I think this is safe to merge.

ia3andy · 2021-11-10T11:26:05Z

@loicmathieu I would feel better if the CI is green, could you rebase from main (this error happened already before on this PR, so it should have been fixed on main in the meantime)

quarkus-bot · 2021-11-10T20:15:07Z

Failing Jobs - Building `4ead0fe`

Status	Name	Step	Failures	Logs	Raw logs
✖	Native Tests - Windows - hibernate-validator	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator

📦 integration-tests/hibernate-validator

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

loicmathieu · 2021-11-12T11:20:41Z

@ia3andy the last CI runs failed on native image test for Hiberate validator, I can see how it can be related to my PR.

ia3andy · 2021-11-12T13:29:25Z

I agree, just we should find out why this test is failing (so it doesn't bother every PRs).. @gsmet any thoughts

ia3andy · 2021-11-15T14:49:23Z

Ok it seems those tests are flaky: #20495
There is an ongoing discussion on zulip.

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 19, 2021

loicmathieu mentioned this pull request Oct 19, 2021

Hibernate & Hibernate with Panache codestart (and their reactive siblings) #20551

Closed

ia3andy reviewed Oct 19, 2021

View reviewed changes

...quarkus/extension-codestarts/hibernate-orm-codestart/base/src.main.resources/application.yml Outdated Show resolved Hide resolved

loicmathieu force-pushed the hibernate-codestart branch 3 times, most recently from a811d16 to d353d27 Compare October 20, 2021 10:08

loicmathieu marked this pull request as ready for review October 20, 2021 10:09

loicmathieu requested review from ia3andy, FroMage and Sanne October 20, 2021 10:09

loicmathieu force-pushed the hibernate-codestart branch from d353d27 to a4e0a29 Compare October 21, 2021 16:13

ia3andy approved these changes Nov 8, 2021

View reviewed changes

loicmathieu force-pushed the hibernate-codestart branch from 9e88c4f to 630bba8 Compare November 9, 2021 16:03

loicmathieu force-pushed the hibernate-codestart branch from 630bba8 to 45ee91d Compare November 9, 2021 16:16

ia3andy reviewed Nov 9, 2021

View reviewed changes

Add an Hibernate ORM codestart

4ead0fe

loicmathieu force-pushed the hibernate-codestart branch from 45ee91d to 4ead0fe Compare November 10, 2021 17:48

ia3andy merged commit 20ab3f5 into quarkusio:main Nov 15, 2021

quarkus-bot bot added this to the 2.6 - main milestone Nov 15, 2021

loicmathieu deleted the hibernate-codestart branch December 10, 2021 16:43

rsvoboda mentioned this pull request Jan 10, 2022

Hibernate ORM codestart doesn't compile out of the box, jdbc extension is needed #22773

Closed

Add an Hibernate ORM codestart #20879

Add an Hibernate ORM codestart #20879

Conversation

loicmathieu commented Oct 19, 2021

loicmathieu commented Oct 20, 2021

ia3andy commented Oct 20, 2021

loicmathieu commented Oct 20, 2021

quarkus-bot bot commented Oct 20, 2021 • edited Loading

Failing Jobs - Building d353d27

Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-c104dc43-0be3-4b5c-981c-7b5ffaa9edde

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-78cb4975-169b-417a-abb5-b36c36e4d717

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

loicmathieu commented Oct 20, 2021

ia3andy commented Oct 20, 2021

Sanne commented Oct 20, 2021

loicmathieu commented Oct 20, 2021

loicmathieu commented Oct 20, 2021

ia3andy commented Oct 20, 2021

loicmathieu commented Oct 21, 2021

ia3andy commented Oct 21, 2021 • edited Loading

loicmathieu commented Oct 21, 2021

ia3andy commented Oct 21, 2021

loicmathieu commented Oct 21, 2021

ia3andy commented Oct 21, 2021

loicmathieu commented Oct 21, 2021

ia3andy commented Nov 5, 2021

ia3andy left a comment

Choose a reason for hiding this comment

loicmathieu commented Nov 8, 2021

ia3andy commented Nov 8, 2021

loicmathieu commented Nov 8, 2021

ia3andy commented Nov 8, 2021 • edited Loading

ia3andy commented Nov 8, 2021

loicmathieu commented Nov 9, 2021

ia3andy commented Nov 9, 2021 • edited Loading

ia3andy commented Nov 9, 2021

loicmathieu commented Nov 9, 2021

ia3andy commented Nov 9, 2021

loicmathieu commented Nov 9, 2021

quarkus-bot bot commented Nov 9, 2021 • edited Loading

Failing Jobs - Building 45ee91d

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ Native Tests - Windows - hibernate-validator #

📦 integration-tests/hibernate-validator

ia3andy Nov 9, 2021

Choose a reason for hiding this comment

ia3andy commented Nov 10, 2021

loicmathieu commented Nov 10, 2021

ia3andy commented Nov 10, 2021

quarkus-bot bot commented Nov 10, 2021

Failing Jobs - Building 4ead0fe

Failures

⚙️ Native Tests - Windows - hibernate-validator #

📦 integration-tests/hibernate-validator

loicmathieu commented Nov 12, 2021

ia3andy commented Nov 12, 2021

ia3andy commented Nov 15, 2021

quarkus-bot bot commented Oct 20, 2021 •

edited

Loading

Failing Jobs - Building `d353d27`

ia3andy commented Oct 21, 2021 •

edited

Loading

ia3andy commented Nov 8, 2021 •

edited

Loading

ia3andy commented Nov 9, 2021 •

edited

Loading

quarkus-bot bot commented Nov 9, 2021 •

edited

Loading

Failing Jobs - Building `45ee91d`

Failing Jobs - Building `4ead0fe`