Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panache housekeeping #20868

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Panache housekeeping #20868

merged 2 commits into from
Oct 26, 2021

Conversation

loicmathieu
Copy link
Contributor

Remove MongoDB with Panache and Hibernate with Panache classes that are deprecated since 2.1.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/mongodb area/panache labels Oct 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 69d270b

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/panache/mongodb-panache-kotlin/deployment extensions/panache/mongodb-panache/deployment 
! Skipped: docs extensions/panache/mongodb-rest-data-panache/deployment integration-tests/liquibase-mongodb and 3 more

📦 extensions/panache/mongodb-panache-kotlin/deployment

Failed to execute goal org.jetbrains.kotlin:kotlin-maven-plugin:1.5.31:test-compile (test-compile) on project quarkus-mongodb-panache-kotlin-deployment: Compilation failure

📦 extensions/panache/mongodb-panache/deployment

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:testCompile (default-testCompile) on project quarkus-mongodb-panache-deployment: Compilation failure

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 964caf1

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/panache/mongodb-panache/deployment 
! Skipped: docs extensions/panache/mongodb-rest-data-panache/deployment integration-tests/liquibase-mongodb and 2 more

📦 extensions/panache/mongodb-panache/deployment

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:testCompile (default-testCompile) on project quarkus-mongodb-panache-deployment: Compilation failure

@loicmathieu
Copy link
Contributor Author

@gsmet this is the removal of the classes we duplicated in 2.1 to avoid split package.
I'll update the migration guide of 2.5 when merged.

@loicmathieu loicmathieu requested a review from gsmet October 19, 2021 15:06
@loicmathieu loicmathieu added this to the 2.5 - main milestone Oct 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building eae2187

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: integration-tests/mongodb-rest-data-panache 

📦 integration-tests/mongodb-rest-data-panache

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1-jboss-2:compile (default-compile) on project quarkus-integration-test-mongodb-rest-data-panache: Compilation failure

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2021

Failing Jobs - Building 0a943e9

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/vault-agroal 

📦 integration-tests/vault-agroal

io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Maybe add a note in the 2.5 migration guide?

@gsmet gsmet merged commit 13a3ebf into quarkusio:main Oct 26, 2021
@loicmathieu
Copy link
Contributor Author

@gsmet that was the plan ;)
Done, see https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.5
I don't know if it deserves a note inside the anouncement post so I didn't add the label.

@loicmathieu loicmathieu deleted the panache-housekeeping branch October 28, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/mongodb area/panache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants