Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pollute CORS tests output with headers #20838

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Don't pollute CORS tests output with headers #20838

merged 1 commit into from
Oct 18, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 18, 2021 •
edited
Loading

There is no reason to have:

Headers:		Origin=http://custom.origin.quarkus
				Access-Control-Request-Method=GET,POST
				Access-Control-Request-Headers=X-Custom
				Accept=*/*

in the output of these specific tests.

I ran into this when running all the quarkus-vertx-http-deployment tests locally.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2021
@sberyozkin sberyozkin merged commit fd396cf into quarkusio:main Oct 18, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 18, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2021
@geoand geoand deleted the cors-tests-logs branch October 18, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @gastaldi @sberyozkin