-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimised integration between Context Propagation and Mutiny #20743
Conversation
@geoand , @famod : there's an odd failure on a windows specific github action... but it might be related :/ Do you know about that task? I see it has the context propagation No idea how this triggered it, but I see the github action is:
While the errror message states:
Is it possible that last line in the path exclusions needs to be expressed in windows format? I'm just guessing, really not familiar with this. |
Looks like on windows slashes can be expressed in both ways (according to docs at least..) But also, a missing file should generate a warning by default: So I'm not sure. I wonder if it's racy: the gradle cache daemon could have deleted the file after the expression had included it, but before it could have finished the transfer? Since it failed on Windows, I'm not surprised an opened file wasn't locked against deletion. But then again the exlusion pattern should have prevented this.. I'm confused. |
oh, just found this is an existing problem: The relation with context-propagation was a coincidence apparently .. I guess I'll merge then! |
Re-adding 2.3 backport label after the following discussion: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Mailer.3A.20.22Retries.20exhausted.22.20without.20any.20further.20info |
This unlocks significant performance improvements as it allows to skip CP processing in a Mutiny chain, following the existing documentation we have in the CP guide.
(Apparently it wasn't being applied to Mutiny - not sure if to classify it as a bugfix, let's say it's an efficiency improvement)