Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test key elements of compat of the devtools code with the local platform catalog #20740

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Oct 13, 2021

  • test against the local registry (main)
  • Real registry test is @Disabled, we need to test against a snapshot of the real registry (TODO @aloubyansky)

Next step is to also start this test overriding the quarkus-devtools-common version in the eco-system CI to also test the catalog using previous versions of the devtools.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 13, 2021
@ia3andy ia3andy force-pushed the test-devtool-compat branch from 473d741 to 63d3557 Compare October 13, 2021 14:20
@ia3andy ia3andy changed the title Test key elements of compat of the devtools code with the platform catalog (wip) Test key elements of compat of the devtools code with the platform catalog Oct 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 63d3557

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.platform.catalog.CatalogCompatibilityTest.testRegistryPlatformCatalog line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.platform.catalog.CatalogCompatibilityTest.testRegistryPlatformCatalog line 29 - More details - Source on GitHub

java.lang.IllegalStateException: Failed to locate the dev tools config file (.quarkus/config.yaml)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClient.<init>(TestRegistryClient.java:38)
	at io.quarkus.devtools.testing.registry.client.TestRegistryClientFactory.buildRegistryClient(TestRegistryClientFactory.java:32)

@ebullient
Copy link
Member

ebullient commented Oct 18, 2021

We should think about writing this in the ecosystem build using karate (as @maxandersen does for jbang) so that it is testing across projects from the outside.
I would especially love it if this could avoid using the devtools-testing project, as I would love to have something that verifies the behavior we want across versions that isn't subject to change due to refactoring of internals.

@ia3andy ia3andy force-pushed the test-devtool-compat branch 2 times, most recently from 1d8de3f to 81bdb6d Compare November 24, 2021 10:46
@ia3andy ia3andy force-pushed the test-devtool-compat branch from 81bdb6d to 9667e71 Compare November 24, 2021 10:47
@ia3andy ia3andy changed the title (wip) Test key elements of compat of the devtools code with the platform catalog Test key elements of compat of the devtools code with the platform catalog Nov 24, 2021
@ia3andy ia3andy requested a review from aloubyansky November 24, 2021 10:49
@ia3andy ia3andy changed the title Test key elements of compat of the devtools code with the platform catalog Test key elements of compat of the devtools code with the local platform catalog Nov 24, 2021
@ia3andy ia3andy merged commit 40d5f28 into quarkusio:main Nov 24, 2021
@ia3andy ia3andy deleted the test-devtool-compat branch November 24, 2021 15:26
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants