Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin 1.6.0 #20714

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Update to Kotlin 1.6.0 #20714

merged 1 commit into from
Nov 17, 2021

Conversation

evanchooly
Copy link
Member

This is actually bumping to 1.6.0-RC for now. This is to start getting the pieces in place for the eventual release. I'm filing the PR now to make sure we get all the workarounds removed for Kotlin on Java 16. It obviously can't be merged until 1.6.0 is final.

@evanchooly evanchooly requested a review from famod October 12, 2021 20:48
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/kotlin area/panache area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 13, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a221e51

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

famod
famod previously requested changes Oct 14, 2021
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see some movement on this front. 🙂

Btw, this PR now has some merge conflicts.

@famod
Copy link
Member

famod commented Nov 3, 2021

@evanchooly RC2 is out

@famod
Copy link
Member

famod commented Nov 5, 2021

I've rebased this and added RC2.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 6, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 206040a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

@famod
Copy link
Member

famod commented Nov 16, 2021

Rebased again and updated to final 1.6.0. Will probably take a separate stab at those Java 18 problems in another PR.

@gsmet this might be a nice (noteworthy?) addition to 2.5.0.Final.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 16, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c9e53a4

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kafka-streams 

📦 integration-tests/kafka-streams

io.quarkus.it.kafka.streams.KafkaStreamsPropertiesTest.testProperties - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:584)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:657)

@gsmet
Copy link
Member

gsmet commented Nov 16, 2021

As discussed on Zulip, let's make sure it still works with Java 18 EA and let's not backport it to 2.5.

@famod
Copy link
Member

famod commented Nov 16, 2021

let's make sure it still works with Java 18 EA

Done, verified locally.

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes release/noteworthy-feature labels Nov 16, 2021
@gsmet gsmet dismissed famod’s stale review November 16, 2021 18:49

Addressed.

@famod famod merged commit 005c2b4 into quarkusio:main Nov 17, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 17, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 17, 2021
@evanchooly evanchooly deleted the kotlin16 branch December 17, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/kotlin area/panache area/platform Issues related to definition and interaction with Quarkus Platform release/noteworthy-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants