Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize Gradle model builder in a module #20709

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Externalize Gradle model builder in a module #20709

merged 1 commit into from
Oct 15, 2021

Conversation

glefloch
Copy link
Member

This externalize the gradle model into a common module. This will be useful in both plugin in order to be able to serialize the app model.

@glefloch glefloch requested a review from aloubyansky October 12, 2021 19:25
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Oct 12, 2021
glefloch
glefloch commented Oct 12, 2021
View reviewed changes
devtools/gradle/gradle-application-plugin/pom.xml Outdated
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-gradle-tooling</artifactId>
<version>999-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, and I don't like it, but without the version here, it does not compile..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's not in the dependencyManagement of the parent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sibling project, they both have the same parent, should I add a dependencyManagement block ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course, if you don't want to specify the version here.

@aloubyansky
Copy link
Member

You mean it would be used in the extension plugin as well? Could you describe for what?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 12, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ef968c1

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/gradle/gradle-tooling 
! Skipped: devtools/gradle/gradle-application-plugin integration-tests/gradle

📦 devtools/gradle/gradle-tooling

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-tooling: Command execution failed.

@glefloch
Copy link
Member Author

yes, this will be needed in order to run quarkus unit test. This is related to #19504, the quarkus-junit5-internal module needs to resolve the model in beforeAll test hook.

aloubyansky
aloubyansky reviewed Oct 12, 2021
View reviewed changes
devtools/gradle/gradle-application-plugin/pom.xml Outdated
<groupId>io.quarkus</groupId>
<artifactId>quarkus-gradle-tooling</artifactId>
<version>999-SNAPSHOT</version>
<type>pom</type>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this dependency on the pom?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build is handled by gradle using the execute-plugin however the pom is published by maven. without it, when using the plugin, this dependency is not transitively downloaded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a dependency on the JAR. Although it should be on the classpath, right?

aloubyansky
aloubyansky reviewed Oct 12, 2021
View reviewed changes
devtools/gradle/gradle-tooling/pom.xml Outdated
<modelVersion>4.0.0</modelVersion>

<groupId>io.quarkus</groupId>
<artifactId>quarkus-gradle-tooling</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call it quarkus-gradle-model, since it looks like it includes the app model-related API? Or are there other reasons to call it tooling?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm updating the module name

@glefloch glefloch force-pushed the fix/gradle-model-module branch from ef968c1 to 0cf44c0 Compare October 13, 2021 19:06
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 13, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0cf44c0

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/gradle/gradle-model 
! Skipped: devtools/gradle/gradle-application-plugin integration-tests/gradle

📦 devtools/gradle/gradle-model

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (gradle) on project quarkus-gradle-model: Command execution failed.

@glefloch glefloch force-pushed the fix/gradle-model-module branch from 0cf44c0 to 8dbf266 Compare October 14, 2021 15:04
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 14, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8dbf266

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 14, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8dbf266

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

@aloubyansky
Copy link
Member

It looks ok but the windows job keeps failing with the same error

Error: ENOENT: no such file or directory, realpath 'D:\a\quarkus\quarkus\devtools\gradle\gradle-extension-plugin\build\tmp\test\work\.gradle-test-kit\caches\modules-2\metadata-2.97\descriptors\org.eclipse.microprofile.context-propagation\microprofile-context-propagation-parent\1.2\a8be1fe3b3911d3d3425fe720cf42835'

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 15, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 8dbf266

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

@glefloch glefloch force-pushed the fix/gradle-model-module branch from 8dbf266 to 34f4aa3 Compare October 15, 2021 07:03
@glefloch
Copy link
Member Author

Hopefully #20764 will resolve the issue. I rebase my branch to check if everything is ok

@glefloch
Copy link
Member Author

@aloubyansky CI is green with the rebase :)

@aloubyansky aloubyansky merged commit 43d1efc into quarkusio:main Oct 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 15, 2021
@glefloch glefloch deleted the fix/gradle-model-module branch October 15, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@glefloch @aloubyansky