Add support for SmallRye Reactive Messaging RabbitMQ Connector #20659

kdubb · 2021-10-11T02:07:32Z

No runtime features are added. Just the required dependencies and Dev Services support for RabbitMQ.

RabbitMQ Dev Services supports the same features as the AMQP connector's Dev Services, including sharing, labeling and fixed ports. Notably the RabbitMQ Dev Services also support pre-defining exchanges, queues & bindings for started containers.

Correlates to connector added via quarkusio/quarkus#20659

cescoffier

Can you add some integration tests as a new module in the integration-tests directory (then don't forget to add it to the CI). It would be great to have a few tests (both JVM and native) to verify that everything is working.

quarkus-bot · 2021-10-11T14:29:30Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `db7d8c8`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-integration-test-reactive-messaging-rabbitmq: Imports are not sorted in /home/runner/work/quarkus/quarkus/integration-tests/reactive-messaging-rabbitmq/src/test/java/io/quarkus/it/rabbitmq/RabbitMQConnectorTest.java

kdubb · 2021-10-11T15:07:52Z

@cescoffier I've added an integration test based on the test for the Kafka connector

quarkus-bot · 2021-10-11T19:28:08Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `2b37f70`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Upload gc.log`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-rabbitmq integration-tests/rest-client

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <4> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

✖ io.quarkus.it.rest.client.trustall.ExternalTlsTrustAllTestCase.restClient line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

✖ io.quarkus.it.rest.client.wronghost.ExternalWrongHostTestCase.restClient line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <404>.

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/reactive-messaging-rabbitmq integration-tests/vault-agroal

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

quarkus-bot · 2021-10-12T00:58:11Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `80d43fd`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Messaging2	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/reactive-messaging-rabbitmq integration-tests/vault-agroal

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

quarkus-bot · 2021-10-12T05:49:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `34b2338`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - HTTP	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/reactive-messaging-rabbitmq integration-tests/rest-client

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorTest.test line 24 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <5> within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs_java_url - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

quarkus-bot · 2021-10-12T10:40:47Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c1da302`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - HTTP	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Messaging2	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/rest-client integration-tests/vault-agroal

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedTestCase.should_accept_self_signed_certs_java_url line 29 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/vault-agroal

✖ io.quarkus.vault.AgroalVaultITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.AgroalVaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

✖ io.quarkus.vault.VaultKv1ITCase. - More details - Source on GitHub

java.lang.RuntimeException: Error waiting for test resource future to finish.
	at io.quarkus.test.common.TestResourceManager.waitForAllFutures(TestResourceManager.java:151)
	at io.quarkus.test.common.TestResourceManager.start(TestResourceManager.java:136)

⚙️ Native Tests - HTTP #

- Failing: integration-tests/rest-client

📦 integration-tests/rest-client

✖ io.quarkus.it.rest.client.selfsigned.ExternalSelfSignedITCase.should_accept_self_signed_certs_java_url - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

kdubb · 2021-10-12T14:22:24Z

@cescoffier I think the test's are fine and they certainly run 100% of the time locally. There appears to be a CI issue with tests that start a Dev Services container being slow.

quarkus-bot · 2021-10-17T08:44:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `0d9e45a`

Status	Name	Step	Failures	Logs	Raw logs
✖	Native Tests - Messaging2	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/reactive-messaging-rabbitmq

✖ io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

kdubb · 2021-10-22T16:07:52Z

@cescoffier What is need to get this merged?

cescoffier · 2021-10-25T06:51:36Z

...on-tests/reactive-messaging-rabbitmq/src/main/java/io/quarkus/it/rabbitmq/PeopleManager.java

+    }
+
+    public List<Person> getPeople() {
+        log.info("Returning people " + list);


I don't believe we need the log.

cescoffier · 2021-10-25T06:52:08Z

Awesome! Thanks!

kdubb · 2021-10-25T16:35:14Z

@cescoffier Any thoughts about when 3.11.0 will be available so we can bump the version in Quarkus?

Correlates to connector added via quarkusio/quarkus#20659

kdubb added a commit to kdubb/quarkus-quickstarts that referenced this pull request Oct 11, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector

82a4cb6

Correlates to connector added via quarkusio/quarkus#20659

kdubb added a commit to kdubb/quarkus-quickstarts that referenced this pull request Oct 11, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector

cc92946

Correlates to connector added via quarkusio/quarkus#20659

kdubb added a commit to kdubb/quarkus-quickstarts that referenced this pull request Oct 11, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector

620f886

Correlates to connector added via quarkusio/quarkus#20659

kdubb mentioned this pull request Oct 11, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector quarkusio/quarkus-quickstarts#953

Merged

10 tasks

cescoffier requested changes Oct 11, 2021

View reviewed changes

quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Oct 11, 2021

kdubb force-pushed the feature/sr_rm_rabbitmq branch from db7d8c8 to 2b37f70 Compare October 11, 2021 14:55

kdubb force-pushed the feature/sr_rm_rabbitmq branch from 2b37f70 to 80d43fd Compare October 11, 2021 20:07

kdubb force-pushed the feature/sr_rm_rabbitmq branch from 80d43fd to 34b2338 Compare October 12, 2021 01:27

kdubb force-pushed the feature/sr_rm_rabbitmq branch from 34b2338 to c1da302 Compare October 12, 2021 05:57

kdubb force-pushed the feature/sr_rm_rabbitmq branch from c1da302 to 0d9e45a Compare October 17, 2021 03:41

kdubb added 2 commits October 21, 2021 22:54

Add support for SmallRye Reactive Messaging RabbitMQ Connector

7b83ff5

Add simple IT

57e547c

kdubb force-pushed the feature/sr_rm_rabbitmq branch from 0d9e45a to 57e547c Compare October 22, 2021 05:54

cescoffier approved these changes Oct 25, 2021

View reviewed changes

cescoffier merged commit fe1a1c6 into quarkusio:main Oct 25, 2021

quarkus-bot bot added this to the 2.5 - main milestone Oct 25, 2021

kdubb deleted the feature/sr_rm_rabbitmq branch October 25, 2021 16:10

kdubb mentioned this pull request Oct 26, 2021

Security annotations don't work with CompletionStage #20997

Merged

ozangunalp mentioned this pull request Oct 27, 2021

Update to Apicurio Registry 2.1.1.Final and use Vert.x HTTP client #20495

Merged

kdubb added a commit to kdubb/quarkus-quickstarts that referenced this pull request Nov 8, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector

a94f724

Correlates to connector added via quarkusio/quarkus#20659

kdubb added a commit to kdubb/quarkus-quickstarts that referenced this pull request Dec 10, 2021

Add quick start for SmallRye Reactive Messaging RabbitMQ Connector

ffb9544

Correlates to connector added via quarkusio/quarkus#20659

Add support for SmallRye Reactive Messaging RabbitMQ Connector #20659

Add support for SmallRye Reactive Messaging RabbitMQ Connector #20659

Conversation

kdubb commented Oct 11, 2021

cescoffier left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Oct 11, 2021 • edited Loading

Failing Jobs - Building db7d8c8

Failures

⚙️ Initial JDK 11 Build #

📦 integration-tests/reactive-messaging-rabbitmq

kdubb commented Oct 11, 2021

quarkus-bot bot commented Oct 11, 2021 • edited Loading

Failing Jobs - Building 2b37f70

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/rest-client

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/vault-agroal

quarkus-bot bot commented Oct 12, 2021 • edited Loading

Failing Jobs - Building 80d43fd

Failures

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/vault-agroal

⚙️ Native Tests - Messaging2 #

📦 integration-tests/reactive-messaging-rabbitmq

quarkus-bot bot commented Oct 12, 2021 • edited Loading

Failing Jobs - Building 34b2338

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/reactive-messaging-rabbitmq

📦 integration-tests/rest-client

⚙️ Native Tests - HTTP #

📦 integration-tests/rest-client

quarkus-bot bot commented Oct 12, 2021 • edited Loading

Failing Jobs - Building c1da302

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/rest-client

📦 integration-tests/vault-agroal

⚙️ Native Tests - HTTP #

📦 integration-tests/rest-client

⚙️ Native Tests - Messaging2 #

📦 integration-tests/reactive-messaging-rabbitmq

kdubb commented Oct 12, 2021

quarkus-bot bot commented Oct 17, 2021 • edited Loading

Failing Jobs - Building 0d9e45a

Failures

⚙️ Native Tests - Messaging2 #

📦 integration-tests/reactive-messaging-rabbitmq

kdubb commented Oct 22, 2021

cescoffier Oct 25, 2021

Choose a reason for hiding this comment

cescoffier commented Oct 25, 2021

kdubb commented Oct 25, 2021

quarkus-bot bot commented Oct 11, 2021 •

edited

Loading

Failing Jobs - Building `db7d8c8`

quarkus-bot bot commented Oct 11, 2021 •

edited

Loading

Failing Jobs - Building `2b37f70`

quarkus-bot bot commented Oct 12, 2021 •

edited

Loading

Failing Jobs - Building `80d43fd`

quarkus-bot bot commented Oct 12, 2021 •

edited

Loading

Failing Jobs - Building `34b2338`

quarkus-bot bot commented Oct 12, 2021 •

edited

Loading

Failing Jobs - Building `c1da302`

quarkus-bot bot commented Oct 17, 2021 •

edited

Loading

Failing Jobs - Building `0d9e45a`