Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute parser - use standard error report for invalid virtual methods #20587

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Qute parser - use standard error report for invalid virtual methods #20587

merged 1 commit into from
Oct 8, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 7, 2021

The error should look like: Parser error in template [hello.html] on line 8: invalid virtual method in {name.foo()(}.

@mkouba mkouba requested a review from FroMage October 7, 2021 12:42
FroMage
FroMage approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2021

Failing Jobs - Building fa096d1

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc

📦 integration-tests/oidc

✖ io.quarkus.it.keycloak.WebsocketOidcTestCase.websocketTest line 49 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <hello [email protected]> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@mkouba mkouba merged commit 42bca29 into quarkusio:main Oct 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging this pull request may close these issues.

Qute does not tell me which file has an error
2 participants
@mkouba @FroMage