Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Smallrye Reactive Messaging to 3.10.1 #20484

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

ozangunalp
Copy link
Contributor

  • Make autodetect work with Kafka batch support
  • Update Kafka documentation

@Ladicek
Copy link
Contributor

Ladicek commented Oct 1, 2021

Looks fine in general, but added some comments.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 1, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c283bfe

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 143 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

@ozangunalp ozangunalp requested a review from Ladicek October 4, 2021 10:34
@ozangunalp
Copy link
Contributor Author

@Ladicek can we re-run the tests? It is odd that it fails

@Ladicek
Copy link
Contributor

Ladicek commented Oct 4, 2021

I triggered a rerun.


[NOTE]
====
Quarkus autodetects batch types for incoming channels and sets batch configuration automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should something be added to the autodetection chapter?

@Ladicek
Copy link
Contributor

Ladicek commented Oct 5, 2021

Code is fine (much easier to follow than before!), but there's still one thing to be fixed in the docs.

- Make autodetect work with Kafka batch support
- Update Kafka documentation
@Ladicek Ladicek added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 5, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 5, 2021

Failing Jobs - Building dcc66f7

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Upload gc.log ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17

@cescoffier cescoffier merged commit cbe7dee into quarkusio:main Oct 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 6, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 6, 2021
@kdubb
Copy link
Contributor

kdubb commented Oct 7, 2021

@ozangunalp Does this bring smallrye-reactive-messaging-rabbitmq into the Quarkus universe bom?

@ozangunalp
Copy link
Contributor Author

@kdubb no there is no Quarkus extension for smallrye-reactive-messaging-rabbitmq. You can use Quarkus AMQP extension with a RabbitMQ configured with AMQP 1.0 plugin. Or I see that there is a Quarkiverse extension for rabbitmq (https://github.com/quarkiverse/quarkus-rabbitmq-client) but I haven't checked myself.

@rsvoboda
Copy link
Member

rsvoboda commented Oct 7, 2021

Almost feels like this PR should have noteworthy label, especially to highlight Receiving Kafka Records in Batches part. @cescoffier / @ozangunalp wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants