-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Smallrye Reactive Messaging to 3.10.1 #20484
Conversation
ozangunalp
commented
Sep 30, 2021
- Make autodetect work with Kafka batch support
- Update Kafka documentation
...kus/smallrye/reactivemessaging/kafka/deployment/SmallRyeReactiveMessagingKafkaProcessor.java
Outdated
Show resolved
Hide resolved
Looks fine in general, but added some comments. |
4d2df95
to
c283bfe
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building c283bfe
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more 📦 extensions/vertx-http/deployment✖
|
@Ladicek can we re-run the tests? It is odd that it fails |
I triggered a rerun. |
|
||
[NOTE] | ||
==== | ||
Quarkus autodetects batch types for incoming channels and sets batch configuration automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should something be added to the autodetection chapter?
Code is fine (much easier to follow than before!), but there's still one thing to be fixed in the docs. |
c283bfe
to
aec07bf
Compare
- Make autodetect work with Kafka batch support - Update Kafka documentation
aec07bf
to
dcc66f7
Compare
@ozangunalp Does this bring |
@kdubb no there is no Quarkus extension for |
Almost feels like this PR should have noteworthy label, especially to highlight |