Simplify Jackson configuration #20468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by using the build-time-and-runtime-fixed phase and also by using Arc's ability of making config root items beans N.B. This was erroneously done before in quarkusio#14588, but then it didn't work properly because of the Kubernetes Client extension having its dependencies entangled with the Jackson extension. The problem has since been fixed
|
The failures have to do with quay.io being down ATM |
mkouba
approved these changes
Sep 30, 2021
geoand
added
the
triage/waiting-for-ci
Failing Jobs - Building 8f61378
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
Ah cool, I knew I was doing something right :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using the build-time-and-runtime-fixed phase
and also by using Arc's ability of making config root items beans
N.B. This was erroneously done before in #14588 (the reason the PR tests passed was because of the dependency change - this should not have been done), but then it
didn't work properly because of the Kubernetes Client extension
having its dependencies entangled with the Jackson extension.
The problem has since been fixed