Fix quarkus.native.debug-build-process

[zakkak]

As of JDK 9 address needs to specify the host as well. This patch
makes JDWP listen on 0.0.0.0 and is compatible with JDK 8 and JDK >= 9

[jerboaa]

Perhaps this should take the "runs-in-container" property into account? I'd think for local debugging this isn't needed and it would only be exposing more than necessary. Thoughts?

[zakkak]

Perhaps this should take the "runs-in-container" property into account? I'd think for local debugging this isn't needed and it would only be exposing more than necessary. Thoughts?

@jerboaa You mean that we should be using localhost when not running in a container and only use 0.0.0.0 when in a container, right?

[jerboaa]

@jerboaa You mean that we should be using localhost when not running in a container and only use 0.0.0.0 when in a container, right?

Yes. Use the old code to only bind to a specific port locally when not in a container and change to the new 0.0.0.0 address when we are building in a container.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 747fcce

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/container-image/maven-invoker-way 

📦 integration-tests/container-image/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mongo

✖ org.acme.FruitsEndpointTest.testListAllFruits - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

---

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment integration-tests/container-image/maven-invoker-way 
! Skipped: docs integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 2 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

📦 integration-tests/container-image/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.2:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-jib-with-mongo

✖ org.acme.FruitsEndpointTest.testListAllFruits - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

[jerboaa]

Perhaps we could avoid the localhost part? See below.

[jerboaa]

How about?

String debugAgentAddress = DEBUG_BUILD_PROCESS_PORT;
if (isContainerBuild) {
   debugAgentAddress = "0.0.0.0:" + DEBUG_BUILD_PROCESS_PORT;
}
[...]
.add("-J-Xrunjdwp:transport=dt_socket,address=" + debugAgentAddress + ",server=y,suspend=y");

[zakkak]

We sure can, but what's the benefit of it?
This way we make clear that we only want the process to listen on localhost when building locally, do you forsee any issues with this?

[jerboaa]

No it would just be the more backward compatible way, I guess. Looking at the JDK 11 address parsing code "localhost" is handled fine, so feel free to ignore it.