Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI flaky tests: propagate maven.settings #20362

Merged
merged 1 commit into from
Sep 24, 2021
Merged

CLI flaky tests: propagate maven.settings #20362

merged 1 commit into from
Sep 24, 2021

Conversation

ebullient
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus labels Sep 23, 2021
@ebullient ebullient changed the title CLI flaky tests: impose test order CLI flaky tests: impose test order/single thread Sep 23, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 37025f1

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/cli 

📦 devtools/cli

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-cli: Imports are not sorted in /home/runner/work/quarkus/quarkus/devtools/cli/src/test/java/io/quarkus/cli/CliNonProjectTest.java

@aloubyansky
Copy link
Member

How is this change fixing the issue? Alphanumeric ordering?

@ebullient
Copy link
Member Author

I'm not sure. Grasping at straws for what is going on in that one case sometimes.

The knock-on effect of the annotation is to force all tests to run serially/sequentially. There is one indication in the output that a change was detected... so I'm just wondering if there is any way that methods from the test are running at the same time (as they do all basically work within the same space)..

@ebullient
Copy link
Member Author

ebullient commented Sep 23, 2021

Stuart and I looked again, and he made a connection I hadn't regarding where the resources were being pulled from. So I've yanked the test annotations, and replaced w/ a change to propagate maven.settings through tests, too.

@ebullient ebullient changed the title CLI flaky tests: impose test order/single thread CLI flaky tests: propagate maven.settings Sep 23, 2021
@stuartwdouglas stuartwdouglas merged commit b4753fb into quarkusio:main Sep 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021
@ebullient ebullient deleted the cli-tests branch September 24, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants