Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to new SQLServer2016Dialect #20309

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

knutwannheden
Copy link
Contributor

Dialects#guessDialect() should default to the latest version for every dialect.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e88386b

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 16 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 84 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.deployment.ConstantsTest.testDialectNames line 44 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <org.hibernate.dialect.SQLServer2012Dialect> but was: <org.hibernate.dialect.SQLServer2016Dialect>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 84 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.deployment.ConstantsTest.testDialectNames line 44 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <org.hibernate.dialect.SQLServer2012Dialect> but was: <org.hibernate.dialect.SQLServer2016Dialect>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 84 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.deployment.ConstantsTest.testDialectNames line 44 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <org.hibernate.dialect.SQLServer2012Dialect> but was: <org.hibernate.dialect.SQLServer2016Dialect>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

`Dialects#guessDialect()` should default to the latest version for every dialect.
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2021

Failing Jobs - Building f67f571

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@Sanne Sanne merged commit 63bd8db into quarkusio:main Sep 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 21, 2021
@Sanne
Copy link
Member

Sanne commented Sep 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants