Only use `objcopy` in Linux environments #20297

galderz · 2021-09-21T10:32:00Z

Addresses macOS issues in #13856.

objcopy invocations in macOS make the executable crash on startup.
Debug info is only available for Linux,
so avoid objcopy altogether on macOS,
even if present in PATH.
Updated documentation to avoid confusion.

quarkus-bot · 2021-09-21T10:32:03Z

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

zakkak

Thanks @galderz , the patch looks good but I am afraid the warning message in

quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java

Lines 79 to 83 in 0d9d2e4

    
           if (!debugSymbolsEnabled) { 
        
               log.warn( 
        
                       "objcopy executable not found in PATH. Debug symbols will therefore not be separated from the executable."); 
        
               log.warn("That also means that resulting native executable is larger as it embeds the debug symbols."); 
        
           }

might still be misleading.

What do you think about applying something like the following as well?

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java
index d299db7a66..fa0703e27b 100644
--- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java
+++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunner.java
@@ -12,6 +12,7 @@ import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
+import org.apache.commons.lang3.SystemUtils;
 import org.jboss.logging.Logger;
 
 import io.quarkus.deployment.util.ProcessUtil;
@@ -75,12 +76,10 @@ public abstract class NativeImageBuildRunner {
                     // Strip debug symbols regardless, because the underlying JDK might contain them
                     objcopy("--strip-debug", resultingExecutableName);
                 }
-            } else {
-                if (!debugSymbolsEnabled) {
-                    log.warn(
-                            "objcopy executable not found in PATH. Debug symbols will therefore not be separated from the executable.");
-                    log.warn("That also means that resulting native executable is larger as it embeds the debug symbols.");
-                }
+            } else if (SystemUtils.IS_OS_LINUX){
+                log.warn(
+                        "objcopy executable not found in PATH. Debug symbols will therefore not be separated from the executable.");
+                log.warn("That also means that resulting native executable is larger as it embeds the debug symbols.");
             }
             return new Result(0, objcopyExists);
         } finally {
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
index 75ba060b0e..a251cc9733 100644
--- a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
+++ b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
@@ -228,12 +228,7 @@ public class NativeImageBuildStep {
                     final Path finalSources = outputTargetBuildItem.getOutputDirectory().resolve(sources);
                     IoUtils.copy(generatedSources, finalSources);
                     IoUtils.recursiveDelete(generatedSources);
-                } else {
-                    log.warn(
-                            "objcopy executable not found in PATH. Debug symbols therefore cannot be placed into the dedicated directory.");
-                    log.warn("That also means that resulting native executable is larger as it embeds the debug symbols.");
                 }
-
             }
             System.setProperty("native.image.path", finalExecutablePath.toAbsolutePath().toString());

quarkus-bot · 2021-09-21T14:38:56Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `d682129`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 16
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

galderz · 2021-09-22T09:18:55Z

@zakkak Fixed the warning messages. See updated commit.

zakkak

LGTM! Thanks Galder

quarkus-bot · 2021-09-22T09:32:23Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `430fce8`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: core/deployment 
! Skipped: core/test-extension/deployment core/test-extension/runtime devtools/bom-descriptor-json and 606 more

📦 core/deployment

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-core-deployment: Error reading file /home/runner/work/quarkus/quarkus/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

zakkak · 2021-09-22T09:37:11Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

-                    log.warn(
-                            "objcopy executable not found in PATH. Debug symbols therefore cannot be placed into the dedicated directory.");
-                    log.warn("That also means that resulting native executable is larger as it embeds the debug symbols.");
-                }


Hmmm, it looks like you were a bit more aggressive here, we need that } back :)

I'll fix this shortly.

* `objcopy` invocations in macOS make the executable crash on startup. * Debug info is only available for Linux, so avoid `objcopy` altogether on macOS, even if present in PATH. * Updated documentation to avoid confusion. * Adjusted warning messages about `objcopy`.

gsmet · 2021-09-27T09:03:30Z

I rebased and fixed the compilation issue. Let's see how CI goes.

gsmet · 2021-09-27T09:04:33Z

@galderz @zakkak I wonder if this should be backported to 2.2?

/cc @geoand

geoand · 2021-09-27T09:07:22Z

Likely not necessary as @zakkak can best explain

zakkak · 2021-09-27T11:28:51Z

@galderz @zakkak I wonder if this should be backported to 2.2?

@gsmet this is not a blocker, but it would be nice to have it backported.

galderz · 2021-09-28T09:43:04Z

Thx for fixing it @gsmet

galderz · 2021-09-28T09:44:04Z

It'd be nice to backport it. It'd stop people from asking us what is going with this (Max asked us yesterday).

geoand · 2021-09-28T09:52:55Z

Backport to 2.2 you mean?

galderz · 2021-09-28T11:40:58Z

@geoand Yeah backport to 2.2. Let me know if you need a hand with that :)

geoand · 2021-09-28T11:51:43Z

It should be straightforward, but I'll let you if/when the time comes

quarkus-bot bot added area/core area/documentation labels Sep 21, 2021

galderz mentioned this pull request Sep 21, 2021

Native application gets Killed: 9 on macOS Big Sur with binutils on the path #13856

Closed

galderz changed the title ~~Only use objcopy in Linux environments #13856~~ Only use objcopy in Linux environments Sep 21, 2021

cescoffier approved these changes Sep 21, 2021

View reviewed changes

zakkak requested changes Sep 21, 2021

View reviewed changes

galderz force-pushed the t_objcopy_macos branch from d682129 to 430fce8 Compare September 22, 2021 09:18

zakkak approved these changes Sep 22, 2021

View reviewed changes

zakkak requested changes Sep 22, 2021

View reviewed changes

gsmet force-pushed the t_objcopy_macos branch from 430fce8 to 7c12f02 Compare September 27, 2021 09:03

gsmet added the triage/backport? label Sep 27, 2021

geoand merged commit a82a082 into quarkusio:main Sep 28, 2021

quarkus-bot bot added this to the 2.4 - main milestone Sep 28, 2021

geoand added the triage/backport-2.2? label Sep 28, 2021

geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021

geoand removed the triage/backport? label Sep 28, 2021

geoand mentioned this pull request Nov 22, 2021

Objcopy warning when building native executable on Windows #21600

Closed

gsmet modified the milestones: 2.3.0.Final, 2.2.4.Final Nov 30, 2021

gsmet removed the triage/backport-2.2? label Nov 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only use `objcopy` in Linux environments #20297

Only use `objcopy` in Linux environments #20297

galderz commented Sep 21, 2021

quarkus-bot bot commented Sep 21, 2021

zakkak left a comment

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `d682129`

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

galderz commented Sep 22, 2021

zakkak left a comment

quarkus-bot bot commented Sep 22, 2021 •

edited

Loading

Failing Jobs - Building `430fce8`

Failures

⚙️ Initial JDK 11 Build #

📦 core/deployment

zakkak Sep 22, 2021 •

edited

Loading

galderz Sep 28, 2021

gsmet commented Sep 27, 2021

gsmet commented Sep 27, 2021

geoand commented Sep 27, 2021

zakkak commented Sep 27, 2021

galderz commented Sep 28, 2021

galderz commented Sep 28, 2021

geoand commented Sep 28, 2021

galderz commented Sep 28, 2021

geoand commented Sep 28, 2021

	if (!debugSymbolsEnabled) {
	log.warn(
	"objcopy executable not found in PATH. Debug symbols will therefore not be separated from the executable.");
	log.warn("That also means that resulting native executable is larger as it embeds the debug symbols.");
	}

Only use objcopy in Linux environments #20297

Only use objcopy in Linux environments #20297

Conversation

galderz commented Sep 21, 2021

quarkus-bot bot commented Sep 21, 2021

zakkak left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 21, 2021 • edited Loading

Failing Jobs - Building d682129

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

galderz commented Sep 22, 2021

zakkak left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 22, 2021 • edited Loading

Failing Jobs - Building 430fce8

Failures

⚙️ Initial JDK 11 Build #

📦 core/deployment

zakkak Sep 22, 2021 • edited Loading

Choose a reason for hiding this comment

galderz Sep 28, 2021

Choose a reason for hiding this comment

gsmet commented Sep 27, 2021

gsmet commented Sep 27, 2021

geoand commented Sep 27, 2021

zakkak commented Sep 27, 2021

galderz commented Sep 28, 2021

galderz commented Sep 28, 2021

geoand commented Sep 28, 2021

galderz commented Sep 28, 2021

geoand commented Sep 28, 2021

Only use `objcopy` in Linux environments #20297

Only use `objcopy` in Linux environments #20297

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `d682129`

quarkus-bot bot commented Sep 22, 2021 •

edited

Loading

Failing Jobs - Building `430fce8`

zakkak Sep 22, 2021 •

edited

Loading