Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default for printDatafetcherException to true in Dev Mode #20090

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Change the default for printDatafetcherException to true in Dev Mode #20090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...eployment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ public class SmallRyeGraphQLConfig {
Optional<String> defaultErrorMessage;

/**
* Print the data fetcher exception to the log file.
* Print the data fetcher exception to the log file. Default `true` in dev and test mode, default `false` in prod.
*/
@ConfigItem(defaultValue = "false")
boolean printDataFetcherException;
@ConfigItem
Optional<Boolean> printDataFetcherException;

/**
* Make the schema available over HTTP.
Expand Down
16 changes: 16 additions & 0 deletions ...oyment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,22 @@ private Set<String> getAllReferenceClasses(Reference reference) {
return classes;
}

@BuildStep
void printDataFetcherExceptionInDevMode(SmallRyeGraphQLConfig graphQLConfig,
LaunchModeBuildItem launchMode,
BuildProducer<SystemPropertyBuildItem> systemProperties) {

// User did not set this explisitly
if (!graphQLConfig.printDataFetcherException.isPresent()) {
if (launchMode.getLaunchMode().isDevOrTest()) {
systemProperties.produce(new SystemPropertyBuildItem(ConfigKey.PRINT_DATAFETCHER_EXCEPTION, TRUE));
}
} else {
systemProperties.produce(new SystemPropertyBuildItem(ConfigKey.PRINT_DATAFETCHER_EXCEPTION,
String.valueOf(graphQLConfig.printDataFetcherException.get())));
}
}

// Services Integrations

@BuildStep
Expand Down