Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DevServicesContext instead of deprecated QuarkusIntegrationTest.Context #19899

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Sep 3, 2021

Use DevServicesContext instead of deprecated QuarkusIntegrationTest.Context

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 3, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 055df3a

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 16 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 82 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting line 99 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 2 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:43)
	at io.quarkus.hibernate.orm.HibernateHotReloadTestCase.testImportSqlWithContinuousTesting(HibernateHotReloadTestCase.java:99)

⚙️ JVM Tests - JDK 16 #

- Failing: extensions/vertx-http/deployment 
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun line 53 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 2 State{lastRun=1, running=true, inProgress=false, run=1, passed=1, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:43)
	at io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun(IncludePatternTestCase.java:53)

@@ -214,7 +214,7 @@ private void injectTestContext(Object testInstance) {
Class<?> c = testInstance.getClass();
while (c != Object.class) {
for (Field f : c.getDeclaredFields()) {
if (f.getType().equals(QuarkusIntegrationTest.Context.class)) {
if (f.getType().equals(DevServicesContext.class)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsvoboda I wonder if updating QuarkusIntegrationTestExtension is too early, it is fine as it is, but DevServicesContext has only been introduced in main so removing the ability to the support the injection of QuarkusIntegrationTest.Context is early, not sure how much it is used but I can imagine the users seeing theor integration tests starting failing with 2.3.x, just occurred to me this morning...
I think adding a note that it is deprecated to the 2.3 migration guide is what is needed at this stage

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine this way. But I will rebase as it needs at least a JDK build to complete.

@gsmet gsmet force-pushed the DevServicesContext branch from 055df3a to db46a03 Compare October 11, 2021 10:18
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2021
@geoand geoand merged commit c74474c into quarkusio:main Oct 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 12, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants