-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DevServicesContext instead of deprecated QuarkusIntegrationTest.Context #19899
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 055df3a
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/hibernate-orm/deployment
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 82 more 📦 extensions/hibernate-orm/deployment✖
⚙️ JVM Tests - JDK 16 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more 📦 extensions/vertx-http/deployment✖
|
@@ -214,7 +214,7 @@ private void injectTestContext(Object testInstance) { | |||
Class<?> c = testInstance.getClass(); | |||
while (c != Object.class) { | |||
for (Field f : c.getDeclaredFields()) { | |||
if (f.getType().equals(QuarkusIntegrationTest.Context.class)) { | |||
if (f.getType().equals(DevServicesContext.class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rsvoboda I wonder if updating QuarkusIntegrationTestExtension
is too early, it is fine as it is, but DevServicesContext
has only been introduced in main
so removing the ability to the support the injection of QuarkusIntegrationTest.Context
is early, not sure how much it is used but I can imagine the users seeing theor integration tests starting failing with 2.3.x
, just occurred to me this morning...
I think adding a note that it is deprecated to the 2.3 migration guide is what is needed at this stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine this way. But I will rebase as it needs at least a JDK build to complete.
055df3a
to
db46a03
Compare
Use DevServicesContext instead of deprecated QuarkusIntegrationTest.Context