Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of default content type for Multipart handling #19578

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 23, 2021

Also changes the default to UTF-8 and apply some minor polish

Resolves: #19527

Also changes the default to UTF-8 and apply some minor polish

Resolves: quarkusio#19527
@geoand
Copy link
Contributor Author

geoand commented Aug 24, 2021

@stuartwdouglas mind giving this a check as well?

Thanks

Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am just not sure about the property name.

}

@ConfigGroup
public static class InputPartConfigGroup {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really need this extra layer of config? It makes for a very long config property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I did it was to emulate what we have in RESTEasy Classic. I wanted the full config name to be the same (with the only change being swapping resteasy for resteasy-reactive).

@geoand geoand merged commit d1e65ac into quarkusio:main Aug 24, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 24, 2021
@geoand geoand deleted the #19527 branch August 24, 2021 06:05
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RESTEasy Reactive multipart - way to override default charset and content type
3 participants