Fix Fault Tolerance in combination with RestClient Reactive #19537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
|
Draft, because this is a hack and not a proper solution, yet I still find it worth sharing. Plus I want to see CI running in my fork. |
The fault tolerance extension loads bean classes from the deployment classloader during fault tolerance discovery. The classes, as well as discovered fault tolerance annotations, are transferred to runtime, where SmallRye Fault Tolerance applies runtime configuration. This works fine, unless one of the bean classes is generated by another Quarkus extension. These generated classes are stored in memory and the deployment classloader doesn't know about them. Naturally, loading the class fails and aborts the build. The specific problem found was in combination of Fault Tolerance and RestClient Reactive. This commit makes sure that the RestClient generated classes are known to the deployment classloader, but it seems fairly obvious that this is a hacky one-off fix and not a proper solution. I still find it worth sharing :-)
Ladicek
force-pushed
the
fix-fault-tolerance-for-restclient-reactive
branch
from
39848a1 to
fcdbeb2
Compare
Ladicek
changed the title
|
Fixed properly by #19609. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fault tolerance extension loads bean classes from the deployment
classloader during fault tolerance discovery. The classes, as well as
discovered fault tolerance annotations, are transferred to runtime,
where SmallRye Fault Tolerance applies runtime configuration.
This works fine, unless one of the bean classes is generated
by another Quarkus extension. These generated classes are stored
in memory and the deployment classloader doesn't know about them.
Naturally, loading the class fails and aborts the build.
The specific problem found was in combination of Fault Tolerance
and RestClient Reactive. This commit makes sure that the RestClient
generated classes are known to the deployment classloader, but
it seems fairly obvious that this is a hacky one-off fix and
not a proper solution. I still find it worth sharing :-)