-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the guides to refer to the io.quarkus.platform BOMs instead of the universe BOM #19530
Update the guides to refer to the io.quarkus.platform BOMs instead of the universe BOM #19530
Conversation
@@ -795,6 +785,8 @@ We'll take care of provisioning a new repository and set it up to: | |||
- Configure your extension to use the link:https://github.com/quarkusio/quarkus-ecosystem-ci#quarkus-ecosystem-ci[Quarkus Ecosystem CI] to build against the latest Quarkus Core changes; | |||
- Give you the freedom to manage the project and release to Maven Central as you like. | |||
|
|||
NOTE: Extensions hosted in the Quarkiverse Hub may or may not end up in the Quarkus platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any process someone could follow to have a Quarkiverse extension added to the platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would have to be discussed with the platform maintainers. Specifically, the extension should fit the primary purposes/use-cases the platform is targeting and match the quality requirements, i.e. be supersonic, subatomic and work in native.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, just wondering if that would be something that readers might ask frequently, maybe we should elaborate more this note at some point (doesn't need to be in this PR, ofc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a few things.
Could you squash everything when done? Thanks!
docs/src/main/asciidoc/platform.adoc
Outdated
<type>properties</type> | ||
<version>${project.version}</version> | ||
</dependency> | ||
|
||
<!-- Quarkus Core BOM --> | ||
<!-- Quarkus platform BOM --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the platform BOM given you kept it io.quarkus
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, io.quarkus
is a platform but yes, I think it'd be better to change it to io.quarkus.platform
.
docs/src/main/asciidoc/platform.adoc
Outdated
@@ -188,4 +188,4 @@ For example, the `quarkus-universe-bom` platform is based on the `quarkus-bom` p | |||
<!-- skipped content --> | |||
---- | |||
|
|||
That way, the `quarkus-universe-bom` platform properties will appear before the `quarkus-bom` platform properties and so will be dominating during merging. | |||
That way, the `org.acme:acme-quarkus-bom` platform properties will appear before the `io.quarkus:quarkus-bom` platform properties and so will be dominating at build time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, did you want to keep it io.quarkus
?
…ugin Co-authored-by: George Gastaldi <[email protected]> Co-authored-by: Guillaume Smet <[email protected]>
d59e81e
to
4d4346e
Compare
I decided not to change the last example to |
No description provided.