Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the guides to refer to the io.quarkus.platform BOMs instead of the universe BOM #19530

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

aloubyansky
Copy link
Member

No description provided.

@@ -795,6 +785,8 @@ We'll take care of provisioning a new repository and set it up to:
- Configure your extension to use the link:https://github.com/quarkusio/quarkus-ecosystem-ci#quarkus-ecosystem-ci[Quarkus Ecosystem CI] to build against the latest Quarkus Core changes;
- Give you the freedom to manage the project and release to Maven Central as you like.

NOTE: Extensions hosted in the Quarkiverse Hub may or may not end up in the Quarkus platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any process someone could follow to have a Quarkiverse extension added to the platform?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have to be discussed with the platform maintainers. Specifically, the extension should fit the primary purposes/use-cases the platform is targeting and match the quality requirements, i.e. be supersonic, subatomic and work in native.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, just wondering if that would be something that readers might ask frequently, maybe we should elaborate more this note at some point (doesn't need to be in this PR, ofc)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few things.

Could you squash everything when done? Thanks!

docs/src/main/asciidoc/building-my-first-extension.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-my-first-extension.adoc Outdated Show resolved Hide resolved
<type>properties</type>
<version>${project.version}</version>
</dependency>

<!-- Quarkus Core BOM -->
<!-- Quarkus platform BOM -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the platform BOM given you kept it io.quarkus?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, io.quarkus is a platform but yes, I think it'd be better to change it to io.quarkus.platform.

@@ -188,4 +188,4 @@ For example, the `quarkus-universe-bom` platform is based on the `quarkus-bom` p
<!-- skipped content -->
----

That way, the `quarkus-universe-bom` platform properties will appear before the `quarkus-bom` platform properties and so will be dominating during merging.
That way, the `org.acme:acme-quarkus-bom` platform properties will appear before the `io.quarkus:quarkus-bom` platform properties and so will be dominating at build time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, did you want to keep it io.quarkus?

…ugin

Co-authored-by: George Gastaldi <[email protected]>

Co-authored-by: Guillaume Smet <[email protected]>
@aloubyansky aloubyansky force-pushed the docs-refer-to-new-platform-coords branch from d59e81e to 4d4346e Compare August 23, 2021 15:25
@aloubyansky
Copy link
Member Author

I decided not to change the last example to io.quarkus.platform, because I am not sure it's what generally should be used as a base for a custom platform.

@gsmet gsmet merged commit 3277f95 into quarkusio:main Aug 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 23, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants