Add all the properties for MongoDB Service Binding #19517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
previously requested changes
Aug 19, 2021
| } catch (IOException e) { | ||
| throw new IllegalStateException("Unable to determine if file '" + f + "' is a regular file", e); | ||
| } | ||
| File[] files = directory.toFile().listFiles(f -> { |
There was a problem hiding this comment.
This is intentional. We avoid lambdas in runtime code as they have a cost. Please revert this change.
There was a problem hiding this comment.
I've reverted this change.
| @@ -40,4 +43,19 @@ void testK8s() { | |||
| assertThat(binding.getProperties()).containsExactly(entry("test-secret-key", "test-secret-value")); | |||
| } | |||
|
|
|||
| } | |||
| @Test | |||
|
|
|||
There was a problem hiding this comment.
Reverted this change as well as the class under test is reverted.
|
The only changes in this PR now are related to MongoDB binding. For the k8s binding change, I'll open up a discussion regarding the type comparison change with Quarkus community. |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 58d4bfd
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/mongodb-rest-data-panache✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 integration-tests/mongodb-rest-data-panache✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
geoand
reviewed
Aug 23, 2021
|
|
||
| private void setUsername(ServiceBinding binding, Map<String, String> properties) { | ||
| String username = getDbProperty(binding, DB_USER); // encodeIfContainsSpecialCharacters(getDbProperty(binding, DB_USER)); | ||
| LOGGER.info(format("MongoDB username=%s", username)); |
There was a problem hiding this comment.
Are you sure these need to be INFO?
There was a problem hiding this comment.
Not really. They can be at the debug level too. I wasn't sure about the convention, hence, I added them at the info level. If that's not desirable then I can change it to debug.
I also realized that I left a commented part that shouldn't be there anymore (same as where I'm getting username). I'll remove that as well
There was a problem hiding this comment.
Yeah, let's make them debug please
There was a problem hiding this comment.
Let me also look at the integration tests as well. Could be because the connection string property doesn't contain username or password anymore.
geoand
changed the title
geoand
changed the title
|
When done, please squash the commits |
…railing slash before options + handling host and port in one property. Setting Quarkus user/pass separately from connection string. Set log level to debug. Fixed integration tests Logging at debug level instead of info and fixed host+port binding file for integration test failures.
geoand
approved these changes
Aug 23, 2021
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBAAS-42: Added all the properties for MongoDB. Fixed an issue with trailing slash before options + handling host and port in one property. Setting Quarkus user/pass separately from connection string.
Also changed the type comparison by ignoring case