Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension registry user documentation #19503

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

aloubyansky
Copy link
Member

No description provided.

@aloubyansky
Copy link
Member Author

fyi @quarkusio/devtools

@aloubyansky
Copy link
Member Author

And @ebullient who should be added to the @quarkusio/devtools

gsmet
gsmet previously requested changes Aug 19, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions. I find The registry.quarkus.io weird. So I would rather user The registry.quarkus.io registry or something similar. I made some proposals, I'll let you judge of what you prefer.

docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
Copy link
Member

@ebullient ebullient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will come back again to review the repository instructions better. I'm a little sleepy, and reading that part is apparently soporific. ;)

Otherwise, this is mostly nixing unnecessary superlatives. ;)

docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-registry-user.adoc Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Smet <[email protected]>

Co-authored-by: Erin Schnabel <[email protected]>

Co-authored-by: George Gastaldi <[email protected]>
@gastaldi gastaldi merged commit 0fe4312 into quarkusio:main Aug 19, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 19, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants