-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DevServices for Keycloak to support Keycloak-X #19457
Update DevServices for Keycloak to support Keycloak-X #19457
Conversation
...loyment/src/main/java/io/quarkus/oidc/deployment/devservices/keycloak/DevServicesConfig.java
Outdated
Show resolved
Hide resolved
.../main/java/io/quarkus/oidc/deployment/devservices/keycloak/KeycloakDevServicesProcessor.java
Outdated
Show resolved
Hide resolved
This seems pretty useful, what's the status of it? |
We'll have to wait for the next Keycloak-X release containing some fixes (importing the realm works with |
cb447a7
to
d079b08
Compare
d079b08
to
05f1737
Compare
@phillip-kruger @stuartwdouglas I'll follow up with another PR to use Keycloak-X by default once Have a look please and then I'll merge |
Isn't importing the realm fairly important? I don't think it can 'be easily worked around via the admin console' because you can't really use the admin console in tests, and having to do this every time you start dev mode is a terrible user experience. |
@stuartwdouglas Indeed, the quickstart tests won't pass yet - but one can start writing the tests without importing a custom realm as the default realm will be created, with the default users and roles - which can be customized with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an Optional keycloakX config property to override the automatic detection? Looking for '-x' in the image name just feels kinda fragile to me.
05f1737
to
00db64e
Compare
@stuartwdouglas Have a look please, added |
Fixes #19141
Importing the custom realm files does not work, see also https://keycloak.discourse.group/t/keycloak-x-distribution-import-configuration-issue/8583.
Some properties and endpoint addresses have changed - the final PR would support both WildFly and Quarkus based distributions, there will be some extra property like
quarkus.keycloak.devservices.image-distribution=quarkus
(orwildfly
) for the dev services processor to set the properties correctly.CC @pedroigor @stuartwdouglas @phillip-kruger