Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LocaleResolver for RESTEasy Reactive #19196

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 3, 2021

Fixes part of #19171

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, cool, thanks. Totally forgot about this feature!

@geoand
Copy link
Contributor Author

geoand commented Aug 3, 2021

That's better than me, I never knew about it :)

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2021

Failing Jobs - Building a530db1

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

io.quarkus.resteasy.reactive.server.test.simple.SimpleQuarkusRestTestCase.testException line 165 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "OK"
  Actual: An Internal Server Error with stack trace:
java.lang.NullPointerException: Cannot invoke "org.jboss.resteasy.reactive.server.core.ResteasyReactiveRequestContext.getTarget()" because the return value of "org.jboss.resteasy.reactive.server.injection.ContextProducers.getContext()" is null
	at org.jboss.resteasy.reactive.server.injection.ContextProducers.getTarget(ContextProducers.java:108)
	at org.jboss.resteasy.reactive.server.injection.ContextProducers.resourceInfo(ContextProducers.java:90)
	at org.jboss.resteasy.reactive.server.injection.ContextProducers_ProducerMethod_resourceInfo_be7f5503a87442251cde9fbc1d406fb350a529f0_Bean.create(ContextProducers_ProducerMethod_resourceInfo_be7f5503a87442251cde9fbc1d406fb350a529f0_Bean.zig:163)
	at org.jboss.resteasy.reactive.server.injection.ContextProducers_ProducerMethod_resourceInfo_be7f5503a87442251cde9fbc1d406fb350a529f0_Bean....

@geoand geoand merged commit 9aa9a5a into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@geoand geoand deleted the #19171-2 branch August 3, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants