Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use show SQL in the tests #19185

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Don't use show SQL in the tests #19185

merged 1 commit into from
Aug 3, 2021

Conversation

stuartwdouglas
Copy link
Member

This makes the test logs really large, and most of the time makes things
harder to dubug rather than easier.

@stuartwdouglas stuartwdouglas requested a review from Sanne August 3, 2021 01:59
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/panache area/persistence OBSOLETE, DO NOT USE area/smallrye area/spring Issues relating to the Spring integration area/tracing area/vertx labels Aug 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 17f50b8

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
	at io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue(LogSqlFormatSqlDefaultValueTest.java:40)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnit...

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
	at io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue(LogSqlFormatSqlDefaultValueTest.java:40)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnit...

⚙️ JVM Tests - JDK 16 #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue line 40 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <true> but was: <null>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)
	at io.quarkus.hibernate.orm.logsql.LogSqlFormatSqlDefaultValueTest.testFormattedDefaultValue(LogSqlFormatSqlDefaultValueTest.java:40)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnit...

Sanne
Sanne reviewed Aug 3, 2021
View reviewed changes
...che/hibernate-orm-panache/deployment/src/test/resources/application-commented-out.properties Outdated
@@ -3,5 +3,5 @@ quarkus.datasource.devservices.enabled=false
#quarkus.datasource.jdbc.url=jdbc:h2:mem:test
#
#quarkus.hibernate-orm.dialect=org.hibernate.dialect.H2Dialect
#quarkus.hibernate-orm.log.sql=true
##quarkus.hibernate-orm.log.sql=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several cases of these ## double comments.

Sanne
Sanne reviewed Aug 3, 2021
View reviewed changes
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java Outdated
hotReplacementHandler.handle(event);
}
});
httpRouteRouter.route().order(Integer.MIN_VALUE).handler(new TCCLHotReplacementHandler(currentCl));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to belong in this PR?

Sanne
Sanne requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in principle, but need to remove at least the changes to VertxHttpRecorder

@stuartwdouglas
Don't use show SQL in the tests
db2e6b6 
This makes the test logs really large, and most of the time makes things
harder to dubug rather than easier.
Sanne
Sanne approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2021

Failing Jobs - Building db2e6b6

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.sql_load_script.IntroducingDefaultImportScriptTestCase.testAddNewImportSql - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.netty.deployment.NettyProcessor#build threw an exception: java.lang.OutOfMemoryError: Metaspace
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:445)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:405)
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:445)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClas...

@Sanne
Copy link
Member

Sanne commented Aug 3, 2021

Just one failure, and related to metaspace. I guess we know it's not related.

thanks!

@Sanne Sanne merged commit ac075fa into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/panache area/persistence OBSOLETE, DO NOT USE area/smallrye area/spring Issues relating to the Spring integration area/tracing area/vertx
Projects
None yet
Milestone
2.2.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartwdouglas @Sanne