Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - introduce the convenient AnnotationsTransformer.Builder #19166

Merged
merged 1 commit into from
Aug 3, 2021
Merged

ArC - introduce the convenient AnnotationsTransformer.Builder #19166

merged 1 commit into from
Aug 3, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 2, 2021

No description provided.

@mkouba mkouba requested review from Ladicek and manovotn August 2, 2021 12:07
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Aug 2, 2021
Ladicek
Ladicek approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are just nitpicking :-)

@gsmet gsmet changed the title ArC - introduce the convenient AnnotationsTransfromer.Builder ArC - introduce the convenient AnnotationsTransformer.Builder Aug 2, 2021
@mkouba mkouba force-pushed the arc-annotation-transformer-builder branch from b58fe4a to a34adcb Compare August 2, 2021 13:59
@mkouba mkouba marked this pull request as ready for review August 2, 2021 13:59
@mkouba mkouba requested a review from Ladicek August 2, 2021 13:59
@mkouba mkouba force-pushed the arc-annotation-transformer-builder branch from a34adcb to 84c1501 Compare August 2, 2021 14:04
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 84c1501

Status Name Step Test failures Logs Raw logs
✖ Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@mkouba mkouba force-pushed the arc-annotation-transformer-builder branch from 84c1501 to 9a8cbc2 Compare August 2, 2021 14:15
@Ladicek
Copy link
Contributor

Ladicek commented Aug 2, 2021

Must fix that, otherwise LGTM.

@mkouba mkouba force-pushed the arc-annotation-transformer-builder branch from 9a8cbc2 to 3e238a0 Compare August 2, 2021 19:00
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2021
@mkouba mkouba merged commit 5afdd3c into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
manovotn
manovotn reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming fashionably late for a review, but it looks pretty good, so +1 anyway! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn left review comments

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.2.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @Ladicek @manovotn