Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest Client Reactive: do not parse response on error #19084

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

michalszynkiewicz
Copy link
Member

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ed2d61c

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand
Copy link
Contributor

geoand commented Jul 29, 2021

CI is not happy

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-error-mapping branch from ed2d61c to 6a2dc0b Compare July 29, 2021 11:46
@geoand geoand merged commit 976f4ab into quarkusio:main Jul 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 29, 2021
@gsmet
Copy link
Member

gsmet commented Aug 2, 2021

@michalszynkiewicz does it fix a bug and is it something we should consider for backporting to 2.1? If so please add the triage/backport? label. Thanks.

@michalszynkiewicz
Copy link
Member Author

@gsmet I think you are right, the previous behavior was a bug. This is worth backporting (and low risk).

@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants