Move Dev UI Logging closer to Console logging #19078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-kruger
commented
Jul 29, 2021
core/runtime/src/main/java/io/quarkus/runtime/logging/ConsoleConfig.java
Outdated
Show resolved
Hide resolved
geoand
approved these changes
Jul 29, 2021
phillip-kruger
added
the
triage/waiting-for-ci
stuartwdouglas
requested changes
Jul 30, 2021
...-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/logstream/WebSocketLogHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Phillip Kruger <[email protected]>
|
@geoand @stuartwdouglas - changes made as requested. Please check the new BuildItem that now, if included, will enable the logstream in prod |
stuartwdouglas
approved these changes
Jul 30, 2021
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way we create the log handler for Dev UI, so that it's being created when we create the other loggers (like console log). This allows us to set the same filters etc and also show the banner.
Fix #18609
Fix quarkiverse/quarkus-logging-manager#91
Signed-off-by:Phillip Kruger [email protected]