-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer - rework interceptors #19069
Conversation
/cc @ebullient, @kenfinnigan |
...ometer/runtime/src/main/java/io/quarkus/micrometer/runtime/MicrometerCountedInterceptor.java
Outdated
Show resolved
Hide resolved
...crometer/runtime/src/main/java/io/quarkus/micrometer/runtime/MicrometerTimedInterceptor.java
Outdated
Show resolved
Hide resolved
...crometer/runtime/src/main/java/io/quarkus/micrometer/runtime/MicrometerTimedInterceptor.java
Outdated
Show resolved
Hide resolved
f86fa57
to
5591b1b
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5591b1b
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖
✖
✖
✖
📦 integration-tests/kafka-streams✖
📦 integration-tests/micrometer-mp-metrics✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/grpc/deployment✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/micrometer-mp-metrics✖
✖
✖
⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖
✖
✖
✖
✖
✖
📦 integration-tests/kafka-devservices✖
📦 integration-tests/kafka-snappy✖
📦 integration-tests/kafka-ssl✖
📦 integration-tests/kafka-streams✖
📦 integration-tests/kafka✖
📦 integration-tests/micrometer-mp-metrics✖
✖
✖
📦 integration-tests/micrometer-prometheus✖
⚙️ Native Tests - Misc4 #📦 integration-tests/micrometer-mp-metrics✖
✖
✖
|
5591b1b
to
dd613eb
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building dd613eb
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/grpc/deployment✖
✖
✖
✖
✖
✖
✖
✖
⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖
✖
✖
✖
📦 integration-tests/kafka-devservices✖
📦 integration-tests/kafka-snappy✖
📦 integration-tests/kafka-streams✖
📦 integration-tests/main✖
✖
|
- interceptors obtain the metadata from the interceptor bindings instead of InvocationContext.getMethod() and reflection; this makes it possible to reflect "synthetic" annotations added by extensions via annotation transformers - Timed is registered as an additional interceptor binding; MicrometerTimed is no longer necessary - repeatable Timed annotations are now supported - Counted cannot be registered as an additional interceptor binding because it's only applicable to methods - also enhanced the ArcInvocationContext to easily find interceptor binding annotations of a given type
dd613eb
to
cd49175
Compare
...crometer/runtime/src/main/java/io/quarkus/micrometer/runtime/MicrometerTimedInterceptor.java
Show resolved
Hide resolved
@ebullient I think that this PR is ready for final review ;-). |
of InvocationContext.getMethod() and reflection; this makes it possible
to reflect "synthetic" annotations added by extensions via annotation
transformers
MicrometerTimed is no longer necessary
because it's only applicable to methods