Terminate native image build container when Quarkus build terminates #19060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
added
the
triage/waiting-for-ci
Sanne
reviewed
Jul 28, 2021
| .redirectError(ProcessBuilder.Redirect.DISCARD) | ||
| .start(); | ||
| removeProcess.waitFor(2_000, TimeUnit.SECONDS); | ||
| } catch (IOException | InterruptedException e) { |
There was a problem hiding this comment.
right some DB are very slow to stop, but 2000 seconds is a lot! I expect people to think it's hung?
What happens if we don't wait at all, or just wait for some ~10 seconds ?
Also might be nice to include containerName in the logged message, and upgrade it from debug to INFO or WARN ?
There was a problem hiding this comment.
Oh shoot... I mean to have 2 seconds :).
Basically this is just meant to do docker rm -f build-native so it's really esoteric, not much the user can do anyway and it doesn't have much of an effect even if it fails.
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7331