SplitPackageProcessor should also include information about type and classifier of any given app archive #19054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
mkouba
reviewed
Jul 28, 2021
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/SplitPackageProcessor.java
Outdated
Show resolved
Hide resolved
aloubyansky
reviewed
Jul 28, 2021
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/SplitPackageProcessor.java
Outdated
Show resolved
Hide resolved
manovotn
force-pushed
the
splitPackageProcAddTypeAndClassifier
branch
from
cf608cd to
ec729de
Compare
manovotn
changed the title
…classifier of any given app archive.
manovotn
force-pushed
the
splitPackageProcAddTypeAndClassifier
branch
from
ec729de to
d02f682
Compare
aloubyansky
approved these changes
Jul 28, 2021
|
Looking good! The looks a bit funny but well, the important part is that there is now also: |
|
Thanks for checking!
That seems to be a deliberate syntax for when there is not no classifier but there is a type. |
mkouba
added
the
triage/waiting-for-ci
mkouba
approved these changes
Jul 28, 2021
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial improvement for #19030
@famod can you let me know if this gives you more sensible warning messages?