-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeConfigDefault changes ignored on restart #19046
Conversation
Moving to draft for now, as it turns out some Dev Services are relying on this behaviour. |
This ended up being a bit of a substantial dev services cleanup, but I think the end result is cleaner. We also no longer restart them for tests which makes continuous testing a lot faster and more usable. |
This is proving more complex than I had hoped, so I have split the dev services cleanup into #19075 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 64781be
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/arc/deployment✖
✖
⚙️ Native Tests - Data4 #📦 integration-tests/mongodb-panache-kotlin✖
📦 integration-tests/mongodb-rest-data-panache✖
|
This needs a rebase. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building fc835af
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/panache/mongodb-panache/deployment✖
✖
✖
✖
✖
📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
✖
✖
📦 integration-tests/mongodb-panache-kotlin✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/arc/deployment✖
⚙️ JVM Tests - JDK 16 #📦 extensions/panache/mongodb-panache/deployment✖
✖
✖
✖
✖
📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
✖
✖
📦 integration-tests/mongodb-panache-kotlin✖
⚙️ Native Tests - Data4 #📦 integration-tests/mongodb-panache-kotlin✖
📦 integration-tests/mongodb-rest-data-panache✖
|
25c2163
to
00f1fe4
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 00f1fe4
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/panache/mongodb-panache/deployment✖
✖
✖
✖
✖
📦 integration-tests/mongodb-panache-kotlin✖
⚙️ JVM Tests - JDK 11 Windows #📦 extensions/arc/deployment✖
⚙️ JVM Tests - JDK 16 #📦 extensions/arc/deployment✖
⚙️ Native Tests - Data4 #📦 integration-tests/mongodb-panache-kotlin✖
📦 integration-tests/mongodb-rest-data-panache✖
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 00f243d
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/arc/deployment✖
|
554e1c2
to
18f2a20
Compare
@radcortez I have modified this a lot and it should work now, can you have another look? |
18f2a20
to
34cbb2a
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 34cbb2a
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Main #- Failing: integration-tests/main
📦 integration-tests/main✖
⚙️ Native Tests - Messaging1 #- Failing: integration-tests/reactive-messaging-kafka
📦 integration-tests/reactive-messaging-kafka✖
|
34cbb2a
to
83528d7
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 83528d7
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
⚙️ JVM Tests - JDK 16 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
4d78221
to
6181911
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6181911
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6181911
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/hibernate-orm/deployment
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 83 more 📦 extensions/hibernate-orm/deployment✖
|
Also makes sure datasources restart if devservices properties are changed. Fixes quarkusio#17069 Fixes quarkusio#19931
6181911
to
69b98e5
Compare
Map<String, String> defaults = new HashMap<>(); | ||
for (RunTimeConfigurationDefaultBuildItem item : runTimeDefaults) { | ||
if (defaults.putIfAbsent(item.getKey(), item.getValue()) != null) { | ||
throw new IllegalStateException("More than one default value for " + item.getKey() + " was produced"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have stumbled over this validation a few times in the past, since I tried to use this mechanism to set up default values for various config properties which then sometimes conflicted with properties set by other extensions. Specifically, I tried to set a default for the dev-services Docker image name this way.
It seems like this validation no longer exists now and that it may be a case of last build item wins. Meanwhile I found a different solution using a custom config source, but due to the indeterminism it may make sense to keep this validation in place somewhere. Thoughts?
Fixes #17069