Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-5288 Quarkus guide Kogito DMN extension #19027

Merged
merged 1 commit into from
Aug 3, 2021
Merged

KOGITO-5288 Quarkus guide Kogito DMN extension #19027

merged 1 commit into from
Aug 3, 2021

Conversation

tarilabs
Copy link
Contributor

@tarilabs tarilabs commented Jul 27, 2021 •
edited
Loading

@tarilabs tarilabs mentioned this pull request Jul 27, 2021
Merged
10 tasks
gsmet
gsmet requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I spotted a couple of minor things but nothing big. I can apply them if you're at the beach :).

Also, probably good to squash at least some of the commits.

docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/kogito-dmn.adoc Outdated Show resolved Hide resolved
@tarilabs tarilabs force-pushed the tarilabs-20210727-KOGITO-5288 branch from 868e44d to 25b2de2 Compare August 3, 2021 14:40
@tarilabs tarilabs force-pushed the tarilabs-20210727-KOGITO-5288 branch from 25b2de2 to efa1cb0 Compare August 3, 2021 14:50
@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Aug 3, 2021
@gsmet gsmet merged commit cdd304a into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.1.1.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @gsmet