DevTools: fixes and improvements calculating recommended combinations of extension origins #19003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and include the platform preference into the calculation of an extension combination score when choosing one as the recommended one
quarkus-bot
bot
added
area/devtools
gastaldi
reviewed
Jul 26, 2021
| for (OriginWithPreference o : s.getCollectedOrigins()) { | ||
| combinationScore += Math.pow(extOrigins.size(), | ||
| highestRegistryPreference + 1 - o.getPreference().registryPreference); | ||
| highestRegistryPreference + 1 - o.getPreference().registryPreference) | ||
| * ((double) (Integer.MAX_VALUE + 1 - o.getPreference().platformPreference) / Integer.MAX_VALUE); |
There was a problem hiding this comment.
That's some crazy 💩 going on here 😄
gastaldi
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are for use-cases involving multiple registries in the devtools config with extensions present in multiple registries and multiple catalogs.
These changes make sure non-platform extension catalogs are added once per registry and that the platform preference number is included into the calculation of an extension combination score when choosing the recommended one.
The existing tests were supposed to cover these use-cases but the registries in the tests appeared to be well-tuned (excluding all sorts of redundant extension and platform listing). Testing the current registry.quarkus.io in combination with some local registry config showed things could get pretty messy. I'll follow up with more tests.